refactor: changed QRCodeModal to be normal component instead of modal #1353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii-DFINITY
force-pushed
the
refactor/change-qr-modal-to-component
branch
from
f35a218 to
1f6ad1a
Compare
AntonioVentilii-DFINITY
force-pushed
the
refactor/change-qr-modal-to-component
branch
from
1f6ad1a to
0f48a85
Compare
AntonioVentilii-DFINITY
force-pushed
the
refactor/change-qr-modal-to-component
branch
from
0f48a85 to
a956681
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After a few tries, I found out that the modal created in PR #1339 is not the most efficient way to have the QR code scan. That is why we modified the component to be a normal component to be called as a step in the Send Wizard Modal.
Changes
QRCodeModalwas renamedQRCodeScan.Tests
Created small test to check if the timeout was correctly triggered.
Note
We decided to dispatch events to navigate back, in accordance to the other steps of the Wizard Modal.