feat: created QR modal component #1339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntonioVentilii-DFINITY
force-pushed
the
av/feat/qr-code-modal
branch
2 times, most recently
from
b0b94bb to
523e2d8
Compare
AntonioVentilii-DFINITY
force-pushed
the
av/feat/qr-code-modal
branch
from
523e2d8 to
5d70abe
Compare
…ables and changed function goToStep to consider the case -1
AntonioVentilii-DFINITY
force-pushed
the
av/feat/qr-code-modal
branch
from
9661e37 to
d5833d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For the QR code integration, a new Wizard modal was created to add a further step in the send modals that could leverage the GIX component QR Code Reader. It mostly replicates the code in
nns-dapp.Changes
QRCodeReaderModaland that usesdecodeQrCodefunction.WizardStepso that the QR Code Modal can be rendered inside the current modal it is called from.Tests
There could be no end-to-end test yet because the GIX component
QRCodeReaderModalhas notestIdprop to call it and to trigger events. PR #426 was created and approved in gix-components repo, but we would need to wait for the next release, I imagine.