fix missing backtick typo #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... but there are still errors - now `docz dev` is complaining ``` ./node_modules/docz-theme-default/node_modules/docz/dist/index.m.js Module not found: Can't resolve '~db' in '/Users/100ideas/dev/da-play/0_mock/rbx/node_modules/docz-theme-default/node_modules/docz/dist' ``` so upgraded `docz-theme-default` to `latest` (v1.0.4), deleted `./docz/` cache, and ran `$ ./node_modules/.bin/docz dev`... and got react errors in browser when looking at rbx components in docz: ``` (BaseSimplePropsTable, in code (at simple-props-table.tsx:131)) Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. Check the render method of `BaseSimplePropsTable`. ``` but the components do render and can be clicked. there's just a big error box. 😢 also, there is a mismatch between how the make tasks are named in the Makefile and how they are called from npm package.json scripts. Makefile uses hyphen like 'docs-dev' but package.json uses underscore like 'docs_dev'. Also, in package.json, should build command be 'make' or 'make build'? latter doesn't work for me.
|
fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... but there are still errors - now
docz devis complainingso upgraded
docz-theme-defaulttolatest(v1.0.4), deleted./docz/cache, and ran$ ./node_modules/.bin/docz dev... and got react errors in browser when looking at rbx components in docz:but the components do render and can be clicked. there's just a big error box. 😢
also, there is a mismatch between how the make tasks are named in the Makefile and how they are called from npm package.json scripts. Makefile uses hyphen like 'docs-dev' but package.json uses underscore like 'docs_dev'. Also, in package.json, should build command be 'make' or 'make build'? latter doesn't work for me.