Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docz-theme-default@latest incompatible with simple-props-table #60

Closed
100ideas opened this issue Apr 19, 2019 · 2 comments
Closed

docz-theme-default@latest incompatible with simple-props-table #60

100ideas opened this issue Apr 19, 2019 · 2 comments

Comments

@100ideas
Copy link

100ideas commented Apr 19, 2019

Wanted to run a local dev version to play around in docz. Cloned, npm installed, tried running npm run docs...

and make complained about not having a target: There is a mismatch between how the make tasks are named in the Makefile and how they are called from npm package.json scripts. Makefile uses hyphen like 'docs-dev' but package.json uses underscore like 'docs_dev'.

So fixed that, tried again, and found typo in src/components/navbar/__docs__/navbar.docs.mdx. Fixed that (#59), tried again...

... but nowdocz dev is complaining about about itself:

./node_modules/docz-theme-default/node_modules/docz/dist/index.m.js
Module not found: Can't resolve '~db' in './rbx/node_modules/docz-theme-default/node_modules/docz/dist'

so upgraded docz-theme-default to latest (v1.0.4) (#57), deleted ./docz/ cache, and ran $ ./node_modules/.bin/docz dev... and got react errors in browser when looking at rbx components in docz:

(BaseSimplePropsTable, in code (at simple-props-table.tsx:131)) Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports. Check the render method of `BaseSimplePropsTable`.

The components do render and can be clicked. there's just a big error box. 😢

rbx-issue-54

Lastly, in package.json, should build command be 'make' or 'make build'? latter doesn't work for me.


in conclusion:

  1. package.json scripts calling make commands don't work
  2. docz without latest theme throws error about not finding ~db
  3. docz with latest theme (Update docz-theme-default to the latest version 🚀 #57) has problems with simple-props-table.tsx
    • however, this component does not seem necessary for the docz site to mostly work?

possible solution: remove simple-props-table.tsx for now.

@dfee
Copy link
Owner

dfee commented Jun 11, 2019

1. package.json scripts calling make commands don't work

updated. must've changed it in the makefile w/o updating it in package.json

2. docz without latest theme throws error about not finding ~db

there are quite a few errors now that i've updated all packages. will try and get this up and running shortly.

3. docz with latest theme (#57) has problems with simple-props-table.tsx
    • however, this component does not seem necessary for the docz site to mostly work?

same as with #2.

@dfee
Copy link
Owner

dfee commented Jun 14, 2019

Fixed in next branch, which will soon be merged into master (with a new version pushed).

@dfee dfee closed this as completed Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants