Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#799: clean code improvements #884

Merged
merged 2 commits into from
Dec 10, 2024
Merged

#799: clean code improvements #884

merged 2 commits into from
Dec 10, 2024

Conversation

hohwille
Copy link
Member

cleanup of code style after PR #835

@hohwille hohwille added enhancement New feature or request core FileAccess, ProcessUtil, IdeContext, etc. internal Nothing to be added to CHANGELOG, only internal story labels Dec 10, 2024
@hohwille hohwille added this to the release:2024.12.001 milestone Dec 10, 2024
@hohwille hohwille self-assigned this Dec 10, 2024
@hohwille hohwille linked an issue Dec 10, 2024 that may be closed by this pull request
binaries from zip download lack executable flags #799
Closed
jan-vcapgemini
jan-vcapgemini approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@jan-vcapgemini jan-vcapgemini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@coveralls
Copy link
Collaborator

coveralls commented Dec 10, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 12255203109

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 50 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 67.1%
Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/io/FileAccessImpl.java 50 62.74%
Totals Coverage Status
Change from base Build 12254980253: -0.003%
Covered Lines: 6626
Relevant Lines: 9528
💛 - Coveralls

@hohwille hohwille merged commit 7866298 into devonfw:main Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-vcapgemini jan-vcapgemini jan-vcapgemini approved these changes

Assignees

@hohwille hohwille

Labels
core FileAccess, ProcessUtil, IdeContext, etc. enhancement New feature or request internal Nothing to be added to CHANGELOG, only internal story
Projects
IDEasy board
Status: ✅ Done
Milestone
release:2024.12.001
Development

Successfully merging this pull request may close these issues.

binaries from zip download lack executable flags
3 participants
@hohwille @coveralls @jan-vcapgemini