-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#799: fix zip extraction to preserve file attributes #835
Conversation
Tested on Linux:
And
That looks sane even though 26 vs. 27 but I assume this is MB (1024^2) vs. MiB (1000^2). But currently I cannot know the extracted size but also I now do not have a clue about uncompressed file sizes during unpacking.
And
We can test if we can first summarize the sizes but we would need to traverse the virtual JAR/ZIP filesystem twice then. |
refactoring of progressbar and changing expected result of IJ and AStudio plugin
Progressbar entirely refactored and now correct for extract ZIP/JAR. Overhead when unpacking intellij ZIP (largest example we have) was < 1 second (increased from 22 sec to ~23 sec). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-Reviewed by: @WorkingAmeise Looks good to us apart from some questions. Approving for faster merge, but please check comments.
Co-authored-by: jan-vcapgemini <[email protected]>
fixes #799
I first messed around with
ZipEntry.getExtra()
see this thread but had to give up.Then I started from scratch and found this promising issue and this promising page.
Massive simplification of our code whilst also fixing all preservation of file permissions (not only executable flags but all attributes).