-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add saveDataStringAsImageDataToLibrary api, input datastring as parameter. #28
Open
SansWord
wants to merge
5
commits into
devgeeks:master
Choose a base branch
from
SansWord:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
32df3c0
Add saveDataStringAsImageDataToLibrary api
SansWord 75e98aa
Add validation to call back functions
YvonneYu 7b26fb7
Merge pull request #1 from YvonneYu/master
SansWord a6b4e32
fixed bugs for Android
YvonneYu 1978095
Merge pull request #2 from YvonneYu/master
SansWord File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,21 +7,43 @@ | |
// MIT Licensed | ||
// | ||
|
||
module.exports = { | ||
|
||
saveImageDataToLibrary:function(successCallback, failureCallback, canvasId) { | ||
// successCallback required | ||
module.exports = (function() { | ||
|
||
function validateCallBacks(successCallback, failureCallback){ | ||
|
||
var isValid = true; | ||
|
||
if (typeof successCallback != "function") { | ||
console.log("Canvas2ImagePlugin Error: successCallback is not a function"); | ||
isValid = false; | ||
} | ||
else if (typeof failureCallback != "function") { | ||
console.log("Canvas2ImagePlugin Error: failureCallback is not a function"); | ||
isValid = false; | ||
} | ||
else { | ||
return isValid; | ||
} | ||
|
||
function saveImageDataToLibrary(successCallback, failureCallback, canvasId) { | ||
// successCallback required | ||
if (validateCallBacks(successCallback, failureCallback)) { | ||
var canvas = (typeof canvasId === "string") ? document.getElementById(canvasId) : canvasId; | ||
var imageData = canvas.toDataURL().replace(/data:image\/png;base64,/,''); | ||
return cordova.exec(successCallback, failureCallback, "Canvas2ImagePlugin","saveImageDataToLibrary",[imageData]); | ||
return saveDataStringAsImageDataToLibrary(successCallback, failureCallback, imageData); | ||
} | ||
} | ||
|
||
function saveDataStringAsImageDataToLibrary(successCallback, failureCallback, imageData) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using this function to save data string as image to library.
|
||
if (validateCallBacks(successCallback, failureCallback)) { | ||
return cordova.exec(successCallback, failureCallback, | ||
"Canvas2ImagePlugin","saveImageDataToLibrary",[imageData]); | ||
} | ||
} | ||
}; | ||
|
||
return { | ||
saveImageDataToLibrary: saveImageDataToLibrary, | ||
saveDataStringAsImageDataToLibrary: saveDataStringAsImageDataToLibrary | ||
} | ||
|
||
})(); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have to do validation in two apis, so we extract it to this function.