Add saveDataStringAsImageDataToLibrary api, input datastring as parameter. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validations of callbacks in saveDataStringAsImageDataToLibrary.
| // successCallback required | ||
| module.exports = (function() { | ||
|
|
||
| function validateCallBacks(successCallback, failureCallback){ |
There was a problem hiding this comment.
Have to do validation in two apis, so we extract it to this function.
fixed bugs for Android
|
It would be great if this gets merged soon! |
|
Very useful feature. Hope it can land soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since canvas on mobile safari has limitation of width and height,
FYI: http://stackoverflow.com/questions/6081483/maximum-size-of-a-canvas-element
We can not always using canvas to generate dataURL.
So we extends your helpful plugin with one extra api to have string as data to store into Library.
And then we can use XHR to grab a image as blob and then using FileReader#readAsDataURL to read out DataURL.
Then save it into Library.
It works for our project, hopefully can make this Plugin more helpful for others.