Increase java-quarkus container memory limit #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: thepetk <[email protected]>
|
What has changed to now require more memory? |
|
Note 512 mb is tiny anyways for a dev build setup so makes sense just curious what caused out of memory |
Not sure what could have changed, but I can see that the Could the memory requirements have changed for Quarkus? That said, I think the tests against I tried locally, and here is the stack trace I observed from the |
Yes I was looking for their releases https://github.com/quarkusio/quarkus/releases/, most probably a change on their side (probably after release 3.4.1) should have affected our tests. In general what I found while debugging this issue was that the current amount of memory was small so I think moving to |
rm3l
approved these changes
Oct 19, 2023
|
Thanks @rm3l for the review! @maxandersen as you are listed inside the OWNERS of this stack, could you also review this update. If you are ok I can merge it. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: maxandersen, rm3l, thepetk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?:
As it is mentioned in devfile/api#1293 the checks of
odov3andodov2are failing because we reach the memory limit of the container when we are trying to build the quarkus application.I've managed to fix this issue by increasing the component memory limit to
1024Mi.Which issue(s) this PR fixes:
fixes devfile/api#1293
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer:
You can reproduce and test the fix by running locally the
test/check_odov2.sh(the instructions are in the bug issue)