Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quarkus stack fails to pass odov2 and odov3 checks #1293

Closed
Tracked by #1236
thepetk opened this issue Oct 17, 2023 · 1 comment · Fixed by devfile/registry#231
Closed
Tracked by #1236

Quarkus stack fails to pass odov2 and odov3 checks #1293

thepetk opened this issue Oct 17, 2023 · 1 comment · Fixed by devfile/registry#231
Assignees
Labels
area/ci area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library kind/bug Something isn't working

Comments

@thepetk
Copy link
Contributor

thepetk commented Oct 17, 2023

Which area this feature is related to?

/kind bug

Which area this bug is related to?

/area ci
/area registry
/area test-automation

Bug Summary

The checks for PR#225 are failing for both odo v2 and odo v3 stack validation. As you can see in this error trace from odov3 the issue comes from error: http://cwiki.apache.org/confluence/display/MAVEN/OutOfMemoryError

Describe the bug:

During the tests, when we try to build quarkus starter project, the maven project cannot be built as during the build process the container runs out of memory (Java heap space).

To Reproduce:

In order to reproduce this locally you can try to run the check_odov2.sh:

$ cd tests/odov3
$ stackDirs="java-quarkus"
$ currentPath="$(pwd)"
$ stacksPath="$(pwd)/../../stacks"
$ ginkgo run --procs 2 -v -trace --slow-spec-threshold 120s   --timeout 2h   $currentPath -- -stacksPath $stacksPath -stackDirs "$stackDirs"

Expected behavior

The quarkus application should be built successfully

Any logs, error output, screenshots etc? Provide the devfile that sees this bug, if applicable

ci check: https://github.com/devfile/registry/actions/runs/6483831705/job/17707463213?pr=225

Additional context

N/A

Any workaround?

I've tried increasing the memory limit of java-quarkus devfile and it worked locally:

Suggestion on how to fix the bug

In stacks/java-quarkus/devfile.yaml:

components:
  - name: tools
    container:
      image: registry.access.redhat.com/ubi8/openjdk-17:1.17-1.1696520325
      args: ['tail', '-f', '/dev/null']
      memoryLimit: 1024Mi # instead of 512Mi
@thepetk thepetk self-assigned this Oct 17, 2023
@openshift-ci openshift-ci bot added kind/bug Something isn't working area/ci area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library labels Oct 17, 2023
@thepetk thepetk moved this to In Review 👀 in Devfile Project Oct 17, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Oct 17, 2023

I've added the current issue into the sprint 2249 as it currently blocks the PRs created from renovate. I've added the story points that I've spent and created a PR here (devfile/registry#231).

@github-project-automation github-project-automation bot moved this from In Review 👀 to Done ✅ in Devfile Project Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci area/registry Devfile registry for stacks and infrastructure area/test-automation Test automation for devfile specification and library kind/bug Something isn't working
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

1 participant