Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iconUrl check upon index component validation #167

Merged
merged 16 commits into from
Mar 22, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Mar 7, 2023

Please specify the area for this PR
registry/

What does does this PR do / why we need it:
Adds an iconUrl check inside the generator.library.validateIndexComponent func.
This way it blocks the build of the registry if an icon does not exist, or has an invalid url.

Which issue(s) this PR fixes:
devfile/api#1024

Fixes #?

PR acceptance criteria:

  • Test Coverage
    • Are your changes sufficiently tested, and are any applicable test cases added or updated to cover your changes?

Documentation (WIP)

How to test changes / Special notes to the reviewer:

  • Clone locally the devfile registry repo
  • Edit the .ci/Dockerfile git clone command in order to clone the branch of my fork instead of the registry support repo. This way you will be able to test my build tools.
  • Edit an iconUrl from one of the stack/samples and try to build an image of the registry repo locally.

@thepetk thepetk self-assigned this Mar 7, 2023
@codecov
Copy link

codecov bot commented Mar 7, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4bc237b) 43.20% compared to head (182a8df) 43.20%.

❗ Current head 182a8df differs from pull request most recent head e0484d8. Consider uploading reports for the commit e0484d8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   43.20%   43.20%           
=======================================
  Files           6        6           
  Lines        1037     1037           
=======================================
  Hits          448      448           
  Misses        546      546           
  Partials       43       43           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@thepetk thepetk changed the title Add iconUrl check upon index component validation WIP: Add iconUrl check upon index component validation Mar 7, 2023
@thepetk thepetk force-pushed the feature/check_stuck_icons branch from c471793 to 36ab842 Compare March 7, 2023 17:07
index/generator/library/library.go Fixed Show resolved Hide resolved
@thepetk thepetk force-pushed the feature/check_stuck_icons branch 4 times, most recently from ed6b92a to 9c9c61e Compare March 10, 2023 16:15
@thepetk thepetk changed the title WIP: Add iconUrl check upon index component validation Add iconUrl check upon index component validation Mar 10, 2023
thepetk and others added 15 commits March 21, 2023 10:54
Co-authored-by: Michael Valdron <[email protected]>
Signed-off-by: thepetk <[email protected]>
@thepetk thepetk force-pushed the feature/check_stuck_icons branch from 9c9c61e to 182a8df Compare March 21, 2023 10:54
tests/registry/extraDevfileEntries.yaml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 21, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kim-tsao, thepetk
Once this PR has been reviewed and has the lgtm label, please assign johnmcollier for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 22, 2023
@openshift-ci
Copy link

openshift-ci bot commented Mar 22, 2023

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants