Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for icon links on registry build to avoid missing icon links #1024

Closed
elsony opened this issue Feb 7, 2023 · 1 comment
Closed

Check for icon links on registry build to avoid missing icon links #1024

elsony opened this issue Feb 7, 2023 · 1 comment
Assignees
Labels
area/registry Devfile registry for stacks and infrastructure

Comments

@elsony
Copy link
Contributor

elsony commented Feb 7, 2023

Which area/kind this issue is related to?

/area registry

Issue Description

The existing registry build does not check if the icons for a stack/sample are valid and exist or not. This leads to some potential problems that the icon in the registry of a given may be missing, e.g. #1023.

To prevent this to happen in the future, we should

  1. check to make sure the icons are valid during the registry build and fail the registry build if the icons are missing.
  2. see if we can package the icons inside the registry build

Edit by thepetk
Target date: 16/3/2023

@openshift-ci openshift-ci bot added the area/registry Devfile registry for stacks and infrastructure label Feb 7, 2023
@thepetk
Copy link
Contributor

thepetk commented Mar 22, 2023

Closed after the merge of devfile/registry-support#167

@thepetk thepetk closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/registry Devfile registry for stacks and infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants