Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated github actions #99

Merged
merged 5 commits into from
Sep 13, 2023

Conversation

thepetk
Copy link
Contributor

@thepetk thepetk commented Aug 29, 2023

What does this PR do?

This PR updates specific github actions to latest version in order to use NodeJS 16 and not NodeJS 12.
The updated github actions are:

  • actions/checkout@v2 > actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3
  • actions/setup-go@v2 > actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe # v4.1.0

What issues does this PR fix or reference?

fixes devfile/api#1229
fixes devfile/api#1249

Is your PR tested? Consider putting some instruction how to test your changes

The PR simply updates the gotest.yaml workflow in order to use the latest version of two github actions.

@openshift-ci openshift-ci bot requested review from elsony and kim-tsao August 29, 2023 11:51
@thepetk
Copy link
Contributor Author

thepetk commented Aug 29, 2023

/retest

@thepetk
Copy link
Contributor Author

thepetk commented Aug 30, 2023

/retest

@thepetk
Copy link
Contributor Author

thepetk commented Aug 31, 2023

/retest

1 similar comment
@thepetk
Copy link
Contributor Author

thepetk commented Sep 1, 2023

/retest

Signed-off-by: thepetk <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Sep 1, 2023
@thepetk
Copy link
Contributor Author

thepetk commented Sep 1, 2023

I've tried to update go to 1.19 but I see the issue with ODC is that the image https://quay.io/repository/coreos/tectonic-console-builder?tab=tags&tag=v24 used by the workflows failing needs to have a more updated go version.

@michael-valdron
Copy link
Member

fixes devfile/api#1249

@thepetk
Copy link
Contributor Author

thepetk commented Sep 11, 2023

@kim-tsao I've updated the version of tectonic-console-builder used for the failing check to v25 (latest) and now the tests are passing. I don't have the rights to merge to this repo. Feel free to merge if you think we are all set :)

cc @michael-valdron

@michael-valdron michael-valdron mentioned this pull request Sep 11, 2023
@johnmcollier johnmcollier merged commit 23a21ef into devfile:main Sep 13, 2023
@openshift-ci openshift-ci bot added the lgtm label Sep 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnmcollier, kim-tsao, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnmcollier,kim-tsao,thepetk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Integration Test to use Go 1.19 Update deprecated Node.js 12 actions in the integration-tests repo
4 participants