Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated Node.js 12 actions in the integration-tests repo #1229

Closed
3 tasks done
kim-tsao opened this issue Aug 21, 2023 · 4 comments · Fixed by devfile/integration-tests#99
Closed
3 tasks done
Assignees
Labels
kind/user-story User story for new enhancement

Comments

@kim-tsao
Copy link
Contributor

kim-tsao commented Aug 21, 2023

/kind user-story

Which area this user story is related to?

/area integration-tests

User Story

As a devfile developer I want to my github actions updated to the latest, supported Node.js v16 so that my CI workflow will not be disrupted

Acceptance Criteria

@openshift-ci openshift-ci bot added the kind/user-story User story for new enhancement label Aug 21, 2023
@kim-tsao kim-tsao moved this to To Do 📝 in Devfile Project Aug 21, 2023
@thepetk thepetk moved this from To Do 📝 to In Progress 🚧 in Devfile Project Aug 29, 2023
@thepetk thepetk self-assigned this Aug 29, 2023
@thepetk thepetk moved this from In Progress 🚧 to In Review 👀 in Devfile Project Aug 29, 2023
@thepetk
Copy link
Contributor

thepetk commented Aug 30, 2023

@kim-tsao I've created the PR but the ci is failing (not related to our changes). I've tried to retest without success.

@thepetk
Copy link
Contributor

thepetk commented Sep 1, 2023

Still I haven't found the way to fix the ci. It seems there is an issue with the golang version used for the workflow.

@michael-valdron
Copy link
Member

michael-valdron commented Sep 5, 2023

@thepetk Opened related issue #1249 and assigned you. It's tied to the same PR for this issue.

@thepetk
Copy link
Contributor

thepetk commented Sep 11, 2023

The PR which also updates the go version to v1.19 now passes all checks and is good to be merged.

@thepetk thepetk moved this from In Review 👀 to Done ✅ in Devfile Project Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/user-story User story for new enhancement
Projects
Status: Done ✅
Development

Successfully merging a pull request may close this issue.

3 participants