Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New registry viewer build process #51

Merged
merged 11 commits into from
Nov 1, 2022

Conversation

michael-valdron
Copy link
Member

What does this PR do / why we need it:

Provides the following changes:

  • Additional environment variables and build arguments to image build Dockerfile
  • Adds additional shell scripts for building and publishing the registry viewer
  • Add a push image workflow for building the registry viewer image, publishing the registry viewer image, and sending a dispatch to devfile/registry to trigger staging deployment workflows

Which issue(s) this PR fixes:

Fixes #?

part of devfile/api#747

PR acceptance criteria:

  • Unit Tests
  • E2E Tests
  • Documentation

How to test changes / Special notes to the reviewer:

@nx-cloud
Copy link

nx-cloud bot commented Oct 24, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit c8fcb60. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@michael-valdron
Copy link
Member Author

michael-valdron commented Oct 24, 2022

This PR is Blocked, the following repository secrets needs adding:

  • NEXT_PUBLIC_ANALYTICS_WRITE_KEY: Analytics key for the registry viewer No longer needed
  • QUAY_USERNAME: For logging into the account for publishing to quay.io/devfile
  • QUAY_PASSWORD: For logging into the account for publishing to quay.io/devfile
  • REPO_ACCESS_TOKEN: For dispatching to devfile/registry

cc: @johnmcollier @schultzp2020

@michael-valdron
Copy link
Member Author

PR unblocked.

…d CI. Push image workflow uses build_viewer.sh script for building the docker image.

Signed-off-by: Michael Valdron <[email protected]>
Signed-off-by: Michael Valdron <[email protected]>
.github/workflows/pushimage-next.yml Outdated Show resolved Hide resolved
.github/workflows/pushimage-next.yml Outdated Show resolved Hide resolved
@openshift-ci openshift-ci bot added the lgtm label Nov 1, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 1, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michael-valdron, schultzp2020

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 1, 2022
@schultzp2020 schultzp2020 merged commit 3cd8077 into devfile:main Nov 1, 2022
@michael-valdron michael-valdron deleted the viewer-build branch November 3, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants