Define mountSources as being true by default #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the schema to state that `mountSources` will be set to true by default for all non-plugin components. Signed-off-by: John Collier <[email protected]>
johnmcollier
requested review from
amisevsk,
davidfestal and
sleshchenko
as code owners
johnmcollier
changed the title
davidfestal
requested changes
Oct 2, 2020
| // Toggles whether or not the project source code should | ||
| // be mounted in the component. | ||
| // | ||
| // Defaults to true for all component types except plugins and components that set `dedicatedPod` to true. |
There was a problem hiding this comment.
GO-wise, you should change the type to *bool instead of bool if you want to change the default value. But that's slightly less convenient to work with in the GO source code since you have to check whether the field is nil before taking its value.
There was a problem hiding this comment.
Ah, that's a good point @davidfestal. I can update the type.
Signed-off-by: John Collier <[email protected]>
davidfestal
approved these changes
Oct 5, 2020
amisevsk
approved these changes
Oct 5, 2020
JPinkney
approved these changes
Oct 5, 2020
sleshchenko
approved these changes
Oct 6, 2020
sleshchenko
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the devfile schema to define the
mountSourcesfield as being true for all non-plugin components and components that don't setdedicatedPodto true.What issues does this PR fix or reference?
#75
Is your PR tested? Consider putting some instruction how to test your changes
Docs PR