Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mountsources default value for containers #75

Closed
gorkem opened this issue Jun 8, 2020 · 3 comments
Closed

mountsources default value for containers #75

gorkem opened this issue Jun 8, 2020 · 3 comments
Assignees
Labels
area/api Enhancement or issue related to the api/devfile specification kind/enhancement New feature or request severity/P2 Issues that have a major impact
Milestone

Comments

@gorkem
Copy link

gorkem commented Jun 8, 2020

The default value for for mountsources should be true for all component types except for the plugin type.

@l0rd
Copy link
Contributor

l0rd commented Jun 8, 2020

That's a good point because on the other end we have discussed and agreed that the default value for dedicatedPod should be true. But dedicatedPod: true is compatible with mountsources: true only if the storage backend supports RWX OR if we use rsync to sync sources amongst pods.

@l0rd l0rd added the kind/enhancement New feature or request label Jun 8, 2020
@gorkem
Copy link
Author

gorkem commented Jun 8, 2020

I see the point. Perhaps we should just state that if not explicitly defined all components will mountsources except plugin types and those that have dedicatedPod set to be true. This will cover most of the cases.

@l0rd l0rd added this to the 2.0.0 milestone Jun 11, 2020
@l0rd l0rd added the severity/P2 Issues that have a major impact label Jun 11, 2020
@l0rd l0rd added the area/api Enhancement or issue related to the api/devfile specification label Jun 24, 2020
@johnmcollier
Copy link
Member

Closed in #145

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Enhancement or issue related to the api/devfile specification kind/enhancement New feature or request severity/P2 Issues that have a major impact
Projects
None yet
Development

No branches or pull requests

3 participants