-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'Save Checkpoint' button & other regressions #115
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working
✅ Save a new checkpoint worked
✅ Switching to old checkpoint worked
✅ Retraining and not saving, then saving a subsequent retrain worked
Not working
- it seems like the checkpoint list is not 100% correct if I retrain and save multiple times.
- After adding a second checkpoint, when I switched to my first checkpoint the second disappeared from the list
- After switching to one checkpoint, switching to another earlier checkpoint (in this case the base model) seemed to stall
- Tested again after reloading. The issue seems to be reproducible with any second checkpoint applied after a first switch. I do see prediction tiles load in from any saved checkpoint I've selected. However, the
Session Status: Applying Checkpoint
message does not disappear and I am unable to interact until reloading
- Tested again after reloading. The issue seems to be reproducible with any second checkpoint applied after a first switch. I do see prediction tiles load in from any saved checkpoint I've selected. However, the
- Some other bugs flagged in new issues
To Do
- Check on issues listed above
- Duplicate "Save Checkpoint" button in "Predict" tab
@LanesGood I merged #117 and #118 into this because it would be hard to fix conflicts in the state machine later as there is still work to do with checkpoints. I updated the header of this PR with the tickets I'm aiming to fix. |
@LanesGood I added a change to display the 'Save checkpoint' button on both tabs. There is an issue with the backend blocking the checkpoint switch on certain conditions, ticketed at developmentseed/pearl-backend#84. Can you please do another review? |
I was able to successfully test the following: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice @vgeorge, a lot of great work here. Thanks for addressing these changes! We'll fix remaining issues in separate PR's
Contributes to:
cc @LanesGood