Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Save Checkpoint' button & other regressions #115

Merged
merged 15 commits into from
Feb 27, 2024
Merged

Conversation

@vgeorge vgeorge requested a review from LanesGood February 21, 2024 13:22
@vgeorge vgeorge mentioned this pull request Feb 22, 2024
Copy link
Member

@LanesGood LanesGood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working
✅ Save a new checkpoint worked
✅ Switching to old checkpoint worked
✅ Retraining and not saving, then saving a subsequent retrain worked

Not working

  • it seems like the checkpoint list is not 100% correct if I retrain and save multiple times.
  • After adding a second checkpoint, when I switched to my first checkpoint the second disappeared from the list
  • After switching to one checkpoint, switching to another earlier checkpoint (in this case the base model) seemed to stall
    • Tested again after reloading. The issue seems to be reproducible with any second checkpoint applied after a first switch. I do see prediction tiles load in from any saved checkpoint I've selected. However, the Session Status: Applying Checkpoint message does not disappear and I am unable to interact until reloading
  • Some other bugs flagged in new issues

To Do

  • Check on issues listed above
  • Duplicate "Save Checkpoint" button in "Predict" tab

@vgeorge vgeorge mentioned this pull request Feb 26, 2024
@vgeorge
Copy link
Member Author

vgeorge commented Feb 26, 2024

@LanesGood I merged #117 and #118 into this because it would be hard to fix conflicts in the state machine later as there is still work to do with checkpoints. I updated the header of this PR with the tickets I'm aiming to fix.

@LanesGood LanesGood self-requested a review February 26, 2024 14:53
@vgeorge
Copy link
Member Author

vgeorge commented Feb 26, 2024

@LanesGood I added a change to display the 'Save checkpoint' button on both tabs. There is an issue with the backend blocking the checkpoint switch on certain conditions, ticketed at developmentseed/pearl-backend#84. Can you please do another review?

@vgeorge vgeorge changed the title Add 'Save Checkpoint' button Fix 'Save Checkpoint' button & other regressions Feb 27, 2024
@LanesGood
Copy link
Member

LanesGood commented Feb 27, 2024

I was able to successfully test the following:
✅ Bookmarked an AOI
✅ Added a new class
✅ Changed project name in editor

Copy link
Member

@LanesGood LanesGood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice @vgeorge, a lot of great work here. Thanks for addressing these changes! We'll fix remaining issues in separate PR's

@vgeorge vgeorge merged commit 1284ffb into develop Feb 27, 2024
3 checks passed
@vgeorge vgeorge deleted the add/save-checkpoint branch February 27, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants