Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 32-bit (ia32) app-builder.exe on Windows ARM64 #50

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Use 32-bit (ia32) app-builder.exe on Windows ARM64 #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion app-builder-bin/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,15 @@ function getPath() {
if (platform === "darwin") {
return path.join(__dirname, "mac", "app-builder")
}
else if (platform === "win32" && process.arch == "arm64") {
/**
* Golang isn't available for Windows ARM64 yet, so an ARM64 binary
* can't be built yet. However, Windows ARM64 does support ia32
* emulation, so we can leverage the existing executable for ia32.
* https://github.com/golang/go/issues/36439
*/
return path.join(__dirname, "win", "ia32", "app-builder.exe")
}
else if (platform === "win32") {
return path.join(__dirname, "win", process.arch, "app-builder.exe")
}
Expand All @@ -19,4 +28,4 @@ function getPath() {
}
}

exports.appBuilderPath = getPath()
exports.appBuilderPath = getPath()