Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 32-bit (ia32) app-builder.exe on Windows ARM64 #50

Merged
merged 1 commit into from
Mar 1, 2021

Conversation

dennisameling
Copy link
Contributor

Currently, running electron-builder on Windows ARM64 leads to the following error:

• electron-builder  version=22.9.1
  • loaded configuration  file=package.json ("build" field)
  ⨯ spawn C:\repos\Signal-Desktop\node_modules\app-builder-bin\win\arm64\app-builder.exe ENOENT  stackTrace=
                   Error: spawn C:\repos\Signal-Desktop\node_modules\app-builder-bin\win\arm64\app-builder.exe ENOENT
                       at Process.ChildProcess._handle.onexit (internal/child_process.js:269:19)
                       at onErrorNT (internal/child_process.js:465:16)
                       at processTicksAndRejections (internal/process/task_queues.js:80:21)

This is because there's no binary for Windows ARM64 yet. This PR works around that.

Some background
Golang isn't available for Windows ARM64 yet, so an ARM64 binary can't be built yet. However, Windows ARM64 does support ia32 emulation, so we can leverage the existing executable for ia32. Ref: golang/go#36439

@develar develar merged commit 595bb30 into develar:master Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants