Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alias name issue #119

Merged
merged 4 commits into from
Jun 13, 2024
Merged

fix: alias name issue #119

merged 4 commits into from
Jun 13, 2024

Conversation

beyondkmp
Copy link
Contributor

@beyondkmp beyondkmp commented Jun 11, 2024

package.json

{
  "name": "npm-demo",
  "version": "1.0.0",
  "description": "",
  "main": "index.js",
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "keywords": [],
  "author": "",
  "license": "ISC",
  "dependencies": {
          "remote": "npm:@electron/[email protected]"
   }
}

actual results:
{"name":"@electron/remote","version":"2.1.2","dir":"/path/to/node-modules/npm-demo/remote"}

expected result:

{"name":"remote","version":"2.1.2","dir":"/path/to/node-modules/npm-demo/remote"}

Copy link

changeset-bot bot commented Jun 11, 2024

🦋 Changeset detected

Latest commit: 03226e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
app-builder-bin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmaietta
Copy link
Collaborator

Curious, would it be worth adding @electron/remote as a unit test? I'd love to start having PRs expand the test suite so that we can "cover our bases" more reliably for future PRs and prevent regressions :)

@beyondkmp
Copy link
Contributor Author

beyondkmp commented Jun 12, 2024

@mmaietta added @electron/remote as a unit test.

@mmaietta mmaietta merged commit 6a940e4 into develar:master Jun 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants