fix: alias name issue (such as for handling @electron/remote) (#119)

.changeset/green-owls-train.md

@@ -0,0 +1,5 @@
+---
+"app-builder-bin": patch
+---
+
+fix: alias name issue in node modules resolution dependency tree

pkg/node-modules/cli_test.go

@@ -60,7 +60,7 @@ func nodeDepTree(t *testing.T, dir string) {
 		})
 	})
 	g.Expect(r).To(ConsistOf([]string{
-		"react", "js-tokens", "loose-envify",
+		"react", "remote", "js-tokens", "loose-envify",
 	}))
 }
 

pkg/node-modules/nodeModuleCollector.go

@@ -27,6 +27,7 @@ type Dependency struct {
 	conflictDependency map[string]*Dependency
 	dir                string
 	isOptional         int
+	alias              string
 }
 
 type Collector struct {
@@ -237,6 +238,7 @@ func (t *Collector) resolveDependency(parentNodeModuleDir string, name string) (
 	}
 
 	(*dependencyNameToDependency)[name] = dependency
+	dependency.alias = name
 	dependency.dir = dependencyDir
 	return dependency, nil
 }

pkg/node-modules/nodeModuleCollector_test.go

@@ -29,7 +29,7 @@ func TestReadDependencyTreeByNpm(t *testing.T) {
 		return lo.Keys(*it)
 	})
 	g.Expect(r).To(ConsistOf([]string{
-		"js-tokens", "react", "loose-envify",
+		"js-tokens", "react", "remote", "loose-envify",
 	}))
 }
 
@@ -54,6 +54,6 @@ func TestReadDependencyTreeByPnpm(t *testing.T) {
 		return lo.Keys(*it)
 	})
 	g.Expect(r).To(ConsistOf([]string{
-		"js-tokens", "react", "loose-envify",
+		"js-tokens", "react", "remote", "loose-envify",
 	}))
 }