Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons based on new Nerd Fonts version #107

Closed
wants to merge 2 commits into from

Conversation

fadihania
Copy link

Replace the old Material Design Icons, according to Nerd Fonts in latest major release all old mdi icons were remove from the font

Description

According to Nerd Fonts, "The old Material Design Icon codepoints are finally dropped"
https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.0.0

So, the new icons were added and replaced the themes icons. In addition to, introducing new icons for Angular and Karma

Motivation and Context

The Terminal Icons now broken and not showing all icons as before

How Has This Been Tested?

Locally on my machine by creating updated files and test icons in terminal, including Show-TerminalIconsTheme command

Screenshots (if appropriate):

image
image
image

After updates
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

fadihania and others added 2 commits May 28, 2023 23:34
 - Not supported in new Nerd Fonts
 - Add new Material Design icons classes/icons
 - Update devblackops icon them to replace old icons
@ryanspletzer
Copy link

This may be a duplicate of #104.

@fadihania
Copy link
Author

I didn't test that PR but seems that it'll fix the issue too, either one would be good to have soon

@devblackops
Copy link
Owner

Thanks @fadihania. This looks like a dupe of #104. I merged that one and should take care of the v3 NF issue.

@devblackops devblackops closed this Jun 1, 2023
@fadihania
Copy link
Author

Thanks @fadihania. This looks like a dupe of #104. I merged that one and should take care of the v3 NF issue.

That's good for the update to the new Nerd Fonts version, but there's another part about missing icons, colors or those using old logos. These are not part of the #104

Shall I create a separate PR for those updates??

@ryanspletzer
Copy link

@fadihania I would say yes.

@fadihania
Copy link
Author

A new one already created, please have a look #108

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants