-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrating to Nerd Font v3 #104
Conversation
- glyphs.ps1 has been updated with new glyphs -devblackops.psd1 icon theme has been updated with new glyphs -Invoke-TerminalIconsThemeMigration has been added to help users with the migration
Hey @Tiberriver256 I found a few more locations of hard-coded broken glyphs (mostly in documentation)
Here's the code I ran from the root of the repo in case it's useful to find any other glyph references Get-ChildItem -Recurse -File |
Where-Object { $_.Name -ne 'Invoke-TerminalIconsThemeMigration.ps1' } |
ForEach-Object {
$index = 0
$lines = @(
Get-Content -LiteralPath $_.FullName |
Where-Object { $_.Contains('nf-mdi-'); $index += 1 } |
ForEach-Object { 'Line {0}: {1}' -f $index, $_ }
)
if ($lines.Count -gt 0) {
Write-Host $_.FullName -ForegroundColor Red
$lines | Write-Host
}
} |
Good catch @codeleverage. Ironically the Invoke-TerminalIconsThemeMigration.ps1 file works for any text file so I just had to run it on all the ps1 and markdown files haha. |
Nice work @Tiberriver256, I was real glad to see this was already in progress after I unexpectedly broke a bunch of my devtools this morning from upgrading to NFv3! Wanted to mention that I found it helpful to use each glyph's Unicode hex (ex. Any reason to think that could be beneficial to do here as well? Would using the hex codes make the hard-coded glyph definitions easier to maintain in future NF code point changes?
|
Actually, I just noticed in the MS docs that the Unicode escape sequence feature was introduced in PowerShell v6, which probably takes that option off the table if this project is in use by people running it in older Windows PowerShell versions 🤷♂️ |
Thanks for the suggestion! The Glyphs.ps1 file wasn't the tough part of this PR. There's a task in the psakeFile.ps1 file in the root for automatically re-generating it from the HTML on the cheat sheet. The tricky part was that the class names changed, and several were removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @Tiberriver256. I haven't seen this issue because I haven't messed with NF v3 yet. I'll do that and review this and the migration process.
Removing #requires statement
terminal icons have not updated itself to work yet for the new nerd fonts update right? |
Yep, until this PR merges you'll want to still be using 2.x version of Nerd Fonts if you can. |
This should be ready for another build attempt whenever you get the chance @devblackops |
lets pray to god @devblackops to merge the update 🙏 |
Looks good @Tiberriver256. Thanks for the fix! |
May I ask how the update will be made available for PS? I think perhaps by doing |
If you use the out-of-the-box theme, you won't have to do anything other than get the latest version from PowerShell Gallery with Update-Module. If you have your custom icons theme file, you'll want to use the |
@AndreM222 Although the PR has merged, a new release has not been made yet. Once you see a new release pop up on the releases page here, you should be able to pick it up using Update-Module. |
Is there any way to set a notification for the new release 😂? |
Its still in dev right? |
Would love to have this released! |
@devblackops release this asap!! |
Please? |
v0.11.0 has been released! 🎉 Sorry I've been sitting on this for so long. Life has been busy and I've been neglecting my OSS stuff. I'll try my best to keep on top of it from now on. |
It's okay! Thank you so much for publishing it <3 |
Reminder: if you like this library, send devblackops a coffee or something using the GitHub sponsor feature. It's a lot of work to maintain stuff like this. |
Thanks man we really apreciate it. Great stuff 😊 |
- Breaking 2: Material Design Icons Codepoints https://github.com/ryanoasis/nerd-fonts/releases/tag/v3.0.0 - Migrating to Nerd Font v3 devblackops/Terminal-Icons#104
* Migrating to Nerd Font v3 - glyphs.ps1 has been updated with new glyphs -devblackops.psd1 icon theme has been updated with new glyphs -Invoke-TerminalIconsThemeMigration has been added to help users with the migration * Fixing docs and additional files * Added missing documentation for parameters --------- Co-authored-by: Micah Rairdon <[email protected]>
Before
After
I don't think this is quite ready to merge yet but I wanted to get this PR up to get some feedback on it. It should take care of #101 and #103 when it's merged.