Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependabot alert for jupyterlab-3.6.7. #241

Merged
merged 6 commits into from
Mar 28, 2024
Merged

fix: dependabot alert for jupyterlab-3.6.7. #241

merged 6 commits into from
Mar 28, 2024

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Jan 19, 2024

Description

Fix https://github.com/determined-ai/environments/security/dependabot/7

Checklist

  • Bump VERSION to make the pushed images are tagged with the right version.
  • Licenses should be included for new code which was copied and/or modified from any external code.
  • Test the images by running the test bumpenvs procedure in the determined repo. See README.

@@ -20,7 +20,8 @@ RUN python -m pip install determined && python -m pip uninstall -y determined
RUN python -m pip install \
-r /tmp/det_dockerfile_scripts/additional-requirements-torch.txt \
-r /tmp/det_dockerfile_scripts/additional-requirements.txt \
-r /tmp/det_dockerfile_scripts/notebook-requirements.txt
-r /tmp/det_dockerfile_scripts/notebook-requirements.txt && \
jupyter labextension disable "@jupyterlab/apputils-extension:announcements"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this a separate RUN line and maybe add a comment? I want these files to be quickly understandable for external users.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applies to tensorflow-ngc as well.

Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ioga ioga merged commit 079eb6d into main Mar 28, 2024
1 of 2 checks passed
@ioga ioga deleted the jupterlab-vuln branch March 28, 2024 17:48
soohoonchoi added a commit that referenced this pull request Apr 30, 2024
* fix: Tensorboard Profilers (#240)

* Add tensorboard profilers back into images

* update nvidia drivers to 535.161.07 (#246)

minor version upgrade

* feat: NGC+ Image Template (#235)

* add templates for NGC+ images

* add image matrix

* backport lots of improvements to scripts

* remove tf2.8 images

* fix: dependabot alert for `jupyterlab-3.6.7`. (#241)

* Add support to build the tf2-gpu image for Libfabric(OFI) (#251)

* Add support to build the tf2-gpu image for Libfabric(OFI), which incorporates the AWS libfabric plug-in for NCCL to use on Slingshot 11(SS11) networks.

* Increment the VERSION to 0.31.1

* feat: update ngc version (#253)

* feat: update ngc version

* feat: Update naming (#252)

* renaming a bunch of stuff, removing py3.8 and old cuda, changes to CI job names

---------

Co-authored-by: Michael Kardash <[email protected]>
Co-authored-by: Hamid Zare <[email protected]>
Co-authored-by: Ilia Glazkov <[email protected]>
Co-authored-by: Jerry G <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants