Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bumpenvs for jupyter security update. #9077

Merged
merged 1 commit into from
Apr 1, 2024
Merged

chore: bumpenvs for jupyter security update. #9077

merged 1 commit into from
Apr 1, 2024

Conversation

ioga
Copy link
Contributor

@ioga ioga commented Mar 30, 2024

Description

Bumpenvs for determined-ai/environments#241

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@ioga ioga requested review from a team as code owners March 30, 2024 00:27
@cla-bot cla-bot bot added the cla-signed label Mar 30, 2024
@determined-ci determined-ci requested a review from a team March 30, 2024 00:27
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Mar 30, 2024
Copy link

netlify bot commented Mar 30, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 579113f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66075c7a71161c000800020c
😎 Deploy Preview https://deploy-preview-9077--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.06%. Comparing base (b726cf9) to head (579113f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9077      +/-   ##
==========================================
- Coverage   47.06%   47.06%   -0.01%     
==========================================
  Files        1154     1154              
  Lines      142374   142374              
  Branches     2423     2423              
==========================================
- Hits        67010    67005       -5     
- Misses      75174    75179       +5     
  Partials      190      190              
Flag Coverage Δ
backend 42.89% <100.00%> (-0.02%) ⬇️
harness 64.08% <100.00%> (ø)
web 38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/gcp/constants.py 100.00% <100.00%> (ø)
master/internal/config/provconfig/aws_config.go 11.20% <ø> (ø)
master/internal/config/provconfig/gcp_config.go 26.76% <100.00%> (ø)

... and 4 files with indirect coverage changes

Copy link
Contributor

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Infra-relevant parts look ok

@ioga ioga merged commit 4050eda into main Apr 1, 2024
95 of 100 checks passed
@ioga ioga deleted the bumpenvs-ju branch April 1, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants