fix: allow for objects inside array metadata to be typed properly

master/internal/run/runs.go

@@ -1,6 +1,7 @@
 package run
 
 import (
+	"encoding/json"
 	"fmt"
 	"regexp"
 	"strings"
@@ -101,19 +102,35 @@ func flattenMetadata(data map[string]any) (flatMetadata []model.RunMetadataIndex
 				flatMetadata = append(flatMetadata, newIndex)
 				continue
 			}
-			for key, value := range typedVal {
-				newPrefix := entry.prefix + entry.key + "."
-				if newPrefix == "." {
-					newPrefix = ""
+			if entry.array {
+				newIndex := model.RunMetadataIndex{
+					FlatKey:        entry.prefix + entry.key,
+					IsArrayElement: true,
+				}
+				objJSON, err := json.Marshal(entry.value)
+				if err != nil {
+					return nil, fmt.Errorf(
+						"failed to marshall metadata object in array %w",
+						err,
+					)
+				}
+				newIndex.StringValue = ptrs.Ptr(string(objJSON))
+				flatMetadata = append(flatMetadata, newIndex)
+			} else {
+				for key, value := range typedVal {
+					newPrefix := entry.prefix + entry.key + "."
+					if newPrefix == "." {
+						newPrefix = ""
+					}
+					// push the key-value pair onto the stack
+					stack = append(stack, metadataEntry{
+						prefix: newPrefix,
+						key:    key,
+						value:  value,
+						depth:  entry.depth + 1,
+						array:  false,
+					})
 				}
-				// push the key-value pair onto the stack
-				stack = append(stack, metadataEntry{
-					prefix: newPrefix,
-					key:    key,
-					value:  value,
-					depth:  entry.depth + 1,
-					array:  entry.array,
-				})
 			}
 		// if the value is a slice, push each element onto the stack.
 		case []any:

master/internal/run/runs_test.go

@@ -76,9 +76,8 @@ func TestFlattenMetadata(t *testing.T) {
 		},
 		{
 			RunID:          0,
-			FlatKey:        "key7.key8",
-			IntegerValue:   ptrs.Ptr(3),
-			ProjectID:      0,
+			FlatKey:        "key7",
+			StringValue:    ptrs.Ptr(`{"key8":3}`),
 			IsArrayElement: true,
 		},
 		{
@@ -170,8 +169,8 @@ func TestFlattenMetadataArrayNested(t *testing.T) {
 	require.ElementsMatch(t, []model.RunMetadataIndex{
 		{
 			RunID:          0,
-			FlatKey:        "key1.key2",
-			IntegerValue:   ptrs.Ptr(1),
+			FlatKey:        "key1",
+			StringValue:    ptrs.Ptr("{\"key2\":1}"),
 			ProjectID:      0,
 			IsArrayElement: true,
 		},
@@ -289,25 +288,6 @@ func TestFlattenMetadataArrayElementTooLongKey(t *testing.T) {
 	)
 }
 
-func TestFlattenMetadataArrayElementTooLongKeyInNestedArray(t *testing.T) {
-	data := map[string]interface{}{
-		"key1": []interface{}{
-			map[string]interface{}{
-				"key2": 1,
-			},
-		},
-	}
-	data["key1"].([]interface{})[0].(map[string]interface{})[strings.Repeat("a", MaxMetadataKeyLength+1)] = 2
-	_, err := FlattenMetadata(data)
-	require.ErrorContains(
-		t,
-		err,
-		fmt.Sprintf("metadata key exceeds maximum length of %d characters",
-			MaxMetadataKeyLength,
-		),
-	)
-}
-
 func TestFlattenMetadataNestingTooDeep(t *testing.T) {
 	data := map[string]interface{}{}
 	current := data