Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow for objects inside array metadata to be typed properly #9864

Merged
merged 3 commits into from
Aug 28, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Aug 26, 2024

Ticket

ET-744

Description

When an object metadata is inside an array, the object elements are now displayable.

Test Plan

Add metadata to a run that has a list of objects (i.e "a": [{"b": 3}, {"c":2}]) then, on the run table select and confirm that the elements are viewable.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Aug 26, 2024
Copy link

netlify bot commented Aug 26, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 6b31c41
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66ccdebab5fe9100081a994b

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.64%. Comparing base (a1234a1) to head (6b31c41).
Report is 3 commits behind head on main.

Files Patch % Lines
master/internal/run/runs.go 83.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9864      +/-   ##
==========================================
- Coverage   54.66%   54.64%   -0.02%     
==========================================
  Files        1261     1261              
  Lines      156328   156341      +13     
  Branches     3584     3582       -2     
==========================================
- Hits        85463    85439      -24     
- Misses      70733    70770      +37     
  Partials      132      132              
Flag Coverage Δ
backend 45.21% <83.33%> (-0.06%) ⬇️
harness 72.62% <ø> (ø)
web 54.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/run/runs.go 86.88% <83.33%> (-2.11%) ⬇️

... and 7 files with indirect coverage changes

@AmanuelAaron AmanuelAaron marked this pull request as ready for review August 26, 2024 15:44
@AmanuelAaron AmanuelAaron requested a review from a team as a code owner August 26, 2024 15:44
@AmanuelAaron AmanuelAaron merged commit a773551 into main Aug 28, 2024
83 of 96 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/fix-object-in-array-metadata branch August 28, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants