Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add Cluster Name title and change helm value #9775

Merged
merged 4 commits into from
Aug 1, 2024
Merged

chore: add Cluster Name title and change helm value #9775

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d28a75
chore: add cluster name title
amandavialva01 Jul 30, 2024
875a137
change helm additional_rm.name to additional_rm.cluster_name
amandavialva01 Jul 31, 2024
c31bd40
use template literal for cluster name chnage
amandavialva01 Jul 31, 2024
6c36631
change rm.cluster_name default value
amandavialva01 Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion helm/charts/determined/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ resourcePools:
# - resource_manager:
# type: kubernetes
# max_slots_per_pod: 1
# name: carolina-multirm-1
# cluster_name: additional-cluster
# default_namespace: default
# kubeconfig_secret_name: additionalrm
# kubeconfig_secret_value: config
Expand Down
2 changes: 1 addition & 1 deletion webui/react/src/components/WorkspaceCreateModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ const WorkspaceCreateModalComponent: React.FC<Props> = ({ onClose, workspaceId }
<>
{resourceManagers.map((name) => (
<Fragment key={name}>
<Form.Item label={name} name={['bindings', name, 'namespace']}>
<Form.Item label={`Cluster Name: ${name}`} name={['bindings', name, 'namespace']}>
<Input
disabled={watchBindings?.[name]?.['autoCreateNamespace'] ?? false}
maxLength={63}
Expand Down
Loading