-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Cluster Name title and change helm value #9775
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9775 +/- ##
==========================================
- Coverage 54.12% 49.06% -5.06%
==========================================
Files 1257 1082 -175
Lines 154854 141696 -13158
Branches 3487 3485 -2
==========================================
- Hits 83810 69526 -14284
- Misses 70898 72024 +1126
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
bdd5672
to
6c36631
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for adjusting
(cherry picked from commit 13ebf47)
Ticket
Description
additional_resource_managers[i].name
toadditional_resource_managers[i].cluster_name
Before (No title)
After (with title)
Test Plan
CI Passes.
Checklist
docs/release-notes/
See Release Note for details.