-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: change external_run_id to string type in FlatRun proto #9744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9744 +/- ##
=======================================
Coverage 54.12% 54.12%
=======================================
Files 1257 1257
Lines 154768 154768
Branches 3479 3477 -2
=======================================
+ Hits 83762 83763 +1
+ Misses 70860 70859 -1
Partials 146 146
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AmanuelAaron
added
the
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
label
Jul 29, 2024
keita-determined
approved these changes
Jul 29, 2024
jesse-amano-hpe
approved these changes
Jul 29, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jul 29, 2024
(cherry picked from commit 2cdfdf9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-649
Description
External Run Id should be a string in the SearchRuns response
Test Plan
Go to the Runs Table and filter by External Run ID & Tags.
Checklist
docs/release-notes/
See Release Note for details.