Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change external_run_id to string type in FlatRun proto #9744

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

AmanuelAaron
Copy link
Contributor

@AmanuelAaron AmanuelAaron commented Jul 29, 2024

Ticket

ET-649

Description

External Run Id should be a string in the SearchRuns response

Test Plan

Go to the Runs Table and filter by External Run ID & Tags.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 29, 2024
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 01b79e9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66a7de830e4c3a000920bbc4

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.12%. Comparing base (0df7ad3) to head (01b79e9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9744   +/-   ##
=======================================
  Coverage   54.12%   54.12%           
=======================================
  Files        1257     1257           
  Lines      154768   154768           
  Branches     3479     3477    -2     
=======================================
+ Hits        83762    83763    +1     
+ Misses      70860    70859    -1     
  Partials      146      146           
Flag Coverage Δ
backend 44.87% <ø> (+<0.01%) ⬆️
harness 72.62% <ø> (ø)
web 53.39% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/types.ts 99.70% <100.00%> (ø)

... and 4 files with indirect coverage changes

@AmanuelAaron AmanuelAaron added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Jul 29, 2024
@AmanuelAaron AmanuelAaron marked this pull request as ready for review July 29, 2024 17:57
@AmanuelAaron AmanuelAaron requested review from a team as code owners July 29, 2024 17:57
@AmanuelAaron AmanuelAaron merged commit 2cdfdf9 into main Jul 29, 2024
81 of 95 checks passed
@AmanuelAaron AmanuelAaron deleted the aaron_amanuel/fix-external-run-id branch July 29, 2024 18:58
github-actions bot pushed a commit that referenced this pull request Jul 29, 2024
@dannysauer dannysauer restored the aaron_amanuel/fix-external-run-id branch July 29, 2024 20:19
@dannysauer dannysauer deleted the aaron_amanuel/fix-external-run-id branch July 29, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants