Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change external_run_id to string type in FlatRun proto #9744

Merged
merged 3 commits into from
Jul 29, 2024
Merged

fix: change external_run_id to string type in FlatRun proto #9744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df64e9e
fix: change external_run_id to string type in FlatRun proto
Jul 29, 2024
c9e0d2b
update flatrun type
Jul 29, 2024
01b79e9
lint
Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions harness/determined/common/api/bindings.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file modified proto/buf.image.bin
View file
Open in desktop
Binary file not shown.
8 changes: 4 additions & 4 deletions proto/pkg/runv1/run.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion proto/src/determined/run/v1/run.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ message FlatRun {
// Signed searcher metrics value.
optional double searcher_metric_value = 8;
// The id of external run
optional int32 external_run_id = 9;
optional string external_run_id = 9;
// Trial hyperparameters.
optional google.protobuf.Struct hyperparameters = 10;
// summary metrics.
Expand Down
4 changes: 2 additions & 2 deletions webui/react/src/services/api-ts-sdk/api.ts
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion webui/react/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1279,7 +1279,7 @@ export interface FlatRun {
checkpointSize: number;
checkpointCount: number;
searcherMetricValue?: number;
externalRunId?: number;
externalRunId?: string;
hyperparameters?: TrialHyperparameters;
summaryMetrics?: SummaryMetrics;
userId?: number;
Expand Down
Loading