Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deprecate job move within priority group #9624

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

kkunapuli
Copy link
Contributor

@kkunapuli kkunapuli commented Jul 9, 2024

Ticket

RM-321

Description

This is a feature branch merging into main. It's composed of two PRs that were reviewed individually.

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Jul 9, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Jul 9, 2024
@determined-ci determined-ci requested a review from a team July 9, 2024 21:00
Copy link

netlify bot commented Jul 9, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit b293470
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/668da4fb1e8e21000850494c
😎 Deploy Preview https://deploy-preview-9624--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kkunapuli kkunapuli marked this pull request as ready for review July 9, 2024 21:01
@kkunapuli kkunapuli requested review from a team as code owners July 9, 2024 21:01
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 51.71%. Comparing base (f49831c) to head (b293470).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9624      +/-   ##
==========================================
+ Coverage   51.64%   51.71%   +0.06%     
==========================================
  Files        1255     1255              
  Lines      152806   152447     -359     
  Branches     3091     3081      -10     
==========================================
- Hits        78923    78844      -79     
+ Misses      73726    73446     -280     
  Partials      157      157              
Flag Coverage Δ
backend 44.17% <100.00%> (+0.16%) ⬆️
harness 72.76% <0.00%> (ø)
web 48.63% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/db/postgres_jobs.go 92.30% <ø> (+1.00%) ⬆️
master/internal/job/jobservice/jobservice.go 9.48% <ø> (+1.02%) ⬆️
...ster/internal/rm/agentrm/agent_resource_manager.go 49.66% <ø> (+0.43%) ⬆️
master/internal/rm/agentrm/resource_pool.go 39.74% <ø> (+5.61%) ⬆️
...nal/rm/dispatcherrm/dispatcher_resource_manager.go 18.78% <ø> (+0.01%) ⬆️
master/internal/rm/kubernetesrm/job.go 79.61% <ø> (-0.10%) ⬇️
master/internal/rm/kubernetesrm/jobs.go 70.26% <100.00%> (+0.45%) ⬆️
...nal/rm/kubernetesrm/kubernetes_resource_manager.go 31.33% <ø> (+0.41%) ⬆️
master/internal/rm/kubernetesrm/resource_pool.go 85.05% <ø> (+11.42%) ⬆️
master/internal/rm/multirm/multirm.go 82.85% <ø> (-0.39%) ⬇️
... and 7 more

... and 3 files with indirect coverage changes

@keita-determined
Copy link
Contributor

can we have a ticket and description?

@kkunapuli kkunapuli requested review from carolinaecalderon and removed request for a team, azhou-determined, salonig23 and ShreyaLnuHpe July 10, 2024 01:55
@kkunapuli
Copy link
Contributor Author

can we have a ticket and description?

I added a ticket. Sorry for the confusion! Everything in this PR has already been fully reviewed (it was broken up into smaller PRs). This PR puts everything together to merge into main at the same time.

It does not need a full review; a quick glance to ensure nothing strange happened with the merge/rebase is all it needs.

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkunapuli kkunapuli merged commit 1ec5d01 into main Jul 10, 2024
94 of 107 checks passed
@kkunapuli kkunapuli deleted the job-queue-move branch July 10, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants