fix: remove job move actions from webui #9603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## job-queue-move #9603 +/- ##
================================================
Coverage 51.71% 51.71%
================================================
Files 1255 1255
Lines 152575 152447 -128
Branches 3091 3081 -10
================================================
- Hits 78905 78844 -61
+ Misses 73513 73446 -67
Partials 157 157
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kkunapuli
requested review from
NicholasBlaskey,
thiagodallacqua-hpe and
hamidzr
and removed request for
a team and
NicholasBlaskey
thiagodallacqua-hpe
approved these changes
Jul 5, 2024
Comment on lines
-122
to
-129
| const rpTotalJobCount = useCallback( | ||
| (rpName: string) => { | ||
| const stats = rpStats.find((rp) => rp.resourcePool === rpName)?.stats; | ||
| return stats ? stats.queuedCount + stats.scheduledCount : 0; | ||
| }, | ||
| [rpStats], | ||
| ); | ||
|
|
There was a problem hiding this comment.
I get that the objective is to remove the unsupported actions, but, is this part of it? 😅
There was a problem hiding this comment.
Great question! As far as I can tell, rpTotalJobCount is only used to display out of x in the Position in Queue section (that we are removing).
5 tasks
hamidzr
reviewed
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
RM-342
Description
Followup to #9585, which removes the ability for users to update a job's queue position within the same priority group in the backend. Now that actions like "Move To Top" and repositioning a job within "Manage Job" have no effect, remove the buttons from the webui.
"Move to Top" on Resource Pool page should be removed and "Position in Queue" on "Manage Job" pop-up should be removed, as shown in the highlighted section in screenshots.
Test Plan
None needed.
Checklist
docs/release-notes/See Release Note for details.