Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: det gcp down doesn't have a det_version argument #9121

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Apr 8, 2024

Ticket

Description

Test Plan

det deploy gcp down should not fail because of det-version missing

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

RM-153

@hamidzr hamidzr requested a review from a team as a code owner April 8, 2024 14:55
@hamidzr hamidzr requested a review from stoksc April 8, 2024 14:55
@cla-bot cla-bot bot added the cla-signed label Apr 8, 2024
@hamidzr hamidzr requested review from MikhailKardash and removed request for stoksc April 8, 2024 14:55
Copy link

netlify bot commented Apr 8, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f3262e5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66154d741641230008d69839

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 53.32%. Comparing base (c89b3df) to head (f3262e5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9121      +/-   ##
==========================================
+ Coverage   46.18%   53.32%   +7.13%     
==========================================
  Files        1174      770     -404     
  Lines      145186    82361   -62825     
  Branches     2413        0    -2413     
==========================================
- Hits        67054    43916   -23138     
+ Misses      77924    38445   -39479     
+ Partials      208        0     -208     
Flag Coverage Δ
backend 43.55% <ø> (-0.02%) ⬇️
harness 63.99% <0.00%> (ø)
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
harness/determined/deploy/gcp/cli.py 21.00% <0.00%> (ø)

... and 408 files with indirect coverage changes

Copy link
Contributor

@carolinaecalderon carolinaecalderon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamidzr hamidzr enabled auto-merge (squash) April 9, 2024 14:17
@hamidzr hamidzr merged commit ec43809 into main Apr 9, 2024
71 of 84 checks passed
@hamidzr hamidzr deleted the hz-version-check branch April 9, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants