Skip to content

Commit

Permalink
fix: det gcp down doesn't have a det_version argument
Browse files Browse the repository at this point in the history
  • Loading branch information
hamidzr committed Apr 9, 2024
1 parent c89b3df commit f3262e5
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions harness/determined/deploy/gcp/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ def deploy_gcp(command: str, args: argparse.Namespace) -> None:
os.makedirs(args.local_state_path)
os.chdir(args.local_state_path)

deploy_errors.warn_version_mismatch(args.det_version)
if args.det_version is None:
# keep the existing default value behavior of the cli.
args.det_version = determined.__version__

# Set default tf state gcs bucket as '$PROJECT_NAME-determined-deploy` if local tf
# state doesn't exist and user has not provided a gcs bucket.
if (
Expand Down Expand Up @@ -250,6 +245,10 @@ def handle_down(args: argparse.Namespace) -> None:


def handle_up(args: argparse.Namespace) -> None:
deploy_errors.warn_version_mismatch(args.det_version)
if args.det_version is None:
# keep the existing default value behavior of the cli.
args.det_version = determined.__version__
return deploy_gcp("up", args)


Expand Down

0 comments on commit f3262e5

Please sign in to comment.