-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: refactor proto, schema, and jobservice for multiRM #8875
chore: refactor proto, schema, and jobservice for multiRM #8875
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8875 +/- ##
========================================
Coverage 47.54% 47.55%
========================================
Files 1065 1065
Lines 170218 170421 +203
Branches 2241 2241
========================================
+ Hits 80937 81041 +104
- Misses 89123 89222 +99
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
master/static/migrations/20240220144848_add-resource-manager-to-exp.tx.up.sql
Outdated
Show resolved
Hide resolved
b834b79
to
dea6aad
Compare
"resource_manager": { | ||
"type": [ | ||
"string", | ||
"null" | ||
], | ||
"default": "" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this is a dumb question... but why do users need to specify the resource manager and the resource pool?
Why don't we just use resource pools and they specify those? This is a layer of hierarchy that has never made sense to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah this is for use in the multi-RM project -- multiple resource managers can have resource pools with the same name. In that case, we need to use the resource manager name to qualify & identify it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why don't we just disallow multiple resource pools with the same name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hear the answer to this is "because slurm".
Gross, but ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW @rb-determined-ai , the way we're approaching this is users will only need to specify if there is a conflict, still. Otherwise no one knows this param exists.
)" This reverts commit 7c6bec9.
Description
Make changes to api calls to include
ResourceManager
field for requests that call implemented agentRM/kubernetesRMResourceManager
methods.Bubble up these changes to the
jobservice
&ResourceManager
interface.Test Plan
Pass existing tests.
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
RM-43