-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add multirm module to ResourceManager #8857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carolinaecalderon
force-pushed
the
chore-replace-rp-struct
branch
3 times, most recently
from
February 19, 2024 22:23
e8fb827
to
7da5ba2
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
February 20, 2024 09:43
fcb4974
to
5ffb634
Compare
carolinaecalderon
force-pushed
the
chore-replace-rp-struct
branch
from
February 20, 2024 13:16
6de32e4
to
32fbd56
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
February 20, 2024 13:34
81786b6
to
f59b7bd
Compare
carolinaecalderon
force-pushed
the
chore-replace-rp-struct
branch
4 times, most recently
from
February 20, 2024 18:21
283eac3
to
625a8eb
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
2 times, most recently
from
February 20, 2024 20:06
ae9b6ff
to
7f32d4f
Compare
carolinaecalderon
force-pushed
the
chore-replace-rp-struct
branch
3 times, most recently
from
February 20, 2024 21:47
2d2c07a
to
481e835
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
February 20, 2024 21:51
7f32d4f
to
481e835
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8857 +/- ##
==========================================
+ Coverage 47.22% 47.29% +0.07%
==========================================
Files 1162 1162
Lines 175910 176109 +199
Branches 2235 2237 +2
==========================================
+ Hits 83066 83284 +218
+ Misses 92686 92667 -19
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
carolinaecalderon
force-pushed
the
chore-replace-rp-struct
branch
2 times, most recently
from
February 21, 2024 17:10
f1f2ede
to
6f3f00e
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
February 21, 2024 21:14
e68f347
to
b97fbe6
Compare
carolinaecalderon
force-pushed
the
chore-replace-rp-struct
branch
from
February 24, 2024 02:54
70a1acf
to
e647055
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
February 25, 2024 22:48
c514d0a
to
4335916
Compare
carolinaecalderon
force-pushed
the
chore-replace-rp-struct
branch
from
February 26, 2024 02:00
e976eb5
to
626f7c0
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
2 times, most recently
from
February 26, 2024 03:20
3878e37
to
da24a75
Compare
carolinaecalderon
changed the title
chore: refactor master with DefaultRMRouter
chore: add multirm module to ResourceManager
Feb 26, 2024
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
March 4, 2024 16:53
83b539d
to
9ce5b84
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
March 4, 2024 17:55
4f12883
to
6d8b655
Compare
carolinaecalderon
force-pushed
the
carolinac/add-multirm-router-layer
branch
from
March 4, 2024 17:56
6d8b655
to
0d058b4
Compare
carolinaecalderon
added a commit
that referenced
this pull request
Mar 5, 2024
This reverts commit c3012ff.
carolinaecalderon
added a commit
that referenced
this pull request
Mar 5, 2024
carolinaecalderon
added a commit
that referenced
this pull request
Mar 6, 2024
carolinaecalderon
added a commit
that referenced
this pull request
Mar 6, 2024
carolinaecalderon
added a commit
that referenced
this pull request
Mar 6, 2024
carolinaecalderon
added a commit
that referenced
this pull request
Mar 6, 2024
carolinaecalderon
added a commit
that referenced
this pull request
Mar 6, 2024
4 tasks
carolinaecalderon
added a commit
that referenced
this pull request
Mar 7, 2024
carolinaecalderon
added a commit
that referenced
this pull request
Mar 7, 2024
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new
multirm
module and connect this to the master.Add a new
buildrm
function tocore.go
where the rm is initialized.Test Plan
See attached unit tests. In the future, I plan to write e2e tests too.
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
RM-14, RM-38