fix: stop using distutils (for python 3.12) [MLG-1519]

harness/determined/cli/experiment.py

@@ -1,5 +1,4 @@
 import base64
-import distutils.util
 import json
 import numbers
 import pathlib
@@ -1269,7 +1268,7 @@ def experiment_id_arg(help: str) -> Arg:  # noqa: A002
                 ),
                 Arg(
                     "--smaller-is-better",
-                    type=lambda s: bool(distutils.util.strtobool(s)),
+                    type=lambda s: util.strtobool(s),
                     default=None,
                     help="The sort order for metrics when using --sort-by. For "
                     "example, 'accuracy' would require passing '--smaller-is-better false'. If "

harness/determined/common/declarative_argparse.py

@@ -1,4 +1,3 @@
-import distutils.util
 import functools
 import itertools
 from argparse import SUPPRESS, ArgumentDefaultsHelpFormatter, ArgumentParser, Namespace
@@ -247,4 +246,4 @@ def description_sort_key(desc: Any) -> str:
 
 def string_to_bool(s: str) -> bool:
     """Converts string values to boolean for flag arguments (e.g. --active=true)"""
-    return bool(distutils.util.strtobool(s))
+    return util.strtobool(s)

harness/determined/common/util.py

@@ -348,3 +348,15 @@ def wrapper_deprecated(*args: Any, **kwargs: Any) -> Any:
         return cast(U, wrapper_deprecated)
 
     return decorator
+
+
+def strtobool(val: str) -> bool:
+    """
+    A port of the distutils.util.strtobool function, removed in python 3.12.
+
+    The only difference in this function is that any non-falsy value which is a non-empty string is
+    accepted as a true value.  That small difference gives us a small headstart on this todo:
+
+    TODO(MLG-1520): we should instead treat any nonempty string as "true".
+    """
+    return bool(val and val.lower() not in ("n", "no", "f", "false", "off", "0"))

harness/determined/pytorch/_pytorch_context.py

@@ -1023,7 +1023,12 @@ def train_batch(self, batch, epoch_idx, batch_idx):
             # 59.6.0.  The bug is that it attempts to import distutils then access distutils.version
             # without actually importing distutils.version.  We can workaround this by prepopulating
             # the distutils.version submodule in the distutils module.
-            import distutils.version  # noqa: F401
+            #
+            # Except, starting with python 3.12 distutils isn't available at all.
+            try:
+                import distutils.version  # noqa: F401
+            except ImportError:
+                pass
 
             from torch.utils.tensorboard import SummaryWriter
 

harness/determined/pytorch/deepspeed/_deepspeed_context.py

@@ -398,7 +398,12 @@ def train_batch(self, batch, epoch_idx, batch_idx):
             # 59.6.0.  The bug is that it attempts to import distutils then access distutils.version
             # without actually importing distutils.version.  We can workaround this by prepopulating
             # the distutils.version submodule in the distutils module.
-            import distutils.version  # noqa: F401
+            #
+            # Except, starting with python 3.12 distutils isn't available at all.
+            try:
+                import distutils.version  # noqa: F401
+            except ImportError:
+                pass
 
             from torch.utils.tensorboard import SummaryWriter
 

harness/determined/tensorboard/metric_writers/pytorch.py

@@ -12,7 +12,11 @@
 # importing distutils.version.  We can workaround this by prepopulating the distutils.version
 # submodule in the distutils module.
 if version.parse("1.9.0") <= version.parse(torch.__version__) < version.parse("1.11.0"):
-    import distutils.version  # isort:skip  # noqa: F401
+    # Except, starting with python 3.12 distutils isn't available at all.
+    try:
+        import distutils.version  # isort:skip  # noqa: F401
+    except ImportError:
+        pass
 
 from torch.utils.tensorboard import SummaryWriter  # isort:skip