fix: stop using distutils (for python 3.12) [MLG-1519] #8667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils is removed in python 3.12. We shouldn't really be using it anyway, but rather than do a breaking change to switch to the behavior I want us to have, here's a quick fix that unbreaks us, and I made a ticket to do the breaking change at some point in the future. Note that to manifest the failure, you'll need to uninstall setuptools from your python environment (which provides its own distutils package starting in python 3.12).
✅ Deploy Preview for determined-ui canceled.
|
rb-determined-ai
requested review from
MikhailKardash
and removed request for
daranday
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8667 +/- ##
==========================================
- Coverage 51.47% 51.46% -0.02%
==========================================
Files 882 882
Lines 156059 156068 +9
Branches 2085 2085
==========================================
- Hits 80332 80319 -13
- Misses 74243 74260 +17
- Partials 1484 1489 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils is removed in python 3.12. We shouldn't really be using it anyway, but rather than do a breaking change to switch to the behavior I want us to have, here's a quick fix that unbreaks us, and I made a ticket to do the breaking change at some point in the future.
Note that to manifest the failure, you'll need to uninstall setuptools from your python environment (which provides its own distutils package starting in python 3.12).
Test Plan
det -h. With the fix, things work.