Cannot verify an app link correctly #661
Assignees
Labels
kind/bug
Something isn't working
x/profiles
Module that allows to create and manage decentralized social profiles
Milestone
Comments
RiccardoM
added
kind/bug
19 tasks
mergify bot
pushed a commit
that referenced
this issue
Oct 26, 2021
## Description This PR fixes the applications links from not being verified correctly Closes: #661 <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://docs.cosmos.network/v0.44/building-modules/intro.html) - [x] included the necessary unit and integration [tests](https://github.com/desmos-labs/desmos/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug description
Currently it's not possible to verify an application link correctly due to how data is returned from the Band oracle right now.
Steps to reproduce
Expected behavior
The link should be verified correctly and it's status should be set to
APPLICATION_LINK_STATE_VERIFICATION_SUCCESSBug breakdown
This bug was introduced with #652. Inside such PR we changed the application links so that their value must be hex-encoded. However, when an application link verification has been completed by Band, before updating its state to
APPLICATION_LINK_STATE_VERIFICATION_SUCCESSwe require that the returned value from Band oracle is equals to the username specified from the user. Since the Band result is HEX-encoded and the username provided by the user is UTF-8 encoded, this check can never succeed result in all links erroring with the errorinvalid application username.The text was updated successfully, but these errors were encountered: