Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: app links not being verified successfully #662

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

RiccardoM
Copy link
Contributor

@RiccardoM RiccardoM commented Oct 26, 2021

Description

This PR fixes the applications links from not being verified correctly
Closes: #661


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the x/profiles Module that allows to create and manage decentralized social profiles label Oct 26, 2021
Signed-off-by: Riccardo Montagnin <[email protected]>
@@ -30,6 +30,7 @@ type oracleScriptCallData struct {
type resultData struct {
Signature string `obi:"signature"`
Value string `obi:"value"`
Username string `obi:"username"`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To allow to sign arbitrary data, we simply require the oracle to return the signature, the signed value and the username as well

@codecov
Copy link

codecov bot commented Oct 26, 2021

Codecov Report

Merging #662 (8eca2c3) into master (1a22342) will decrease coverage by 68.45%.
The diff coverage is 73.57%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #662       +/-   ##
===========================================
- Coverage   84.23%   15.78%   -68.46%     
===========================================
  Files          91      169       +78     
  Lines        6624    45994    +39370     
===========================================
+ Hits         5580     7262     +1682     
- Misses        833    38109    +37276     
- Partials      211      623      +412     
Impacted Files Coverage Δ
x/profiles/client/cli/cli_app_links.go 34.16% <ø> (ø)
x/profiles/client/cli/cli_params.go 70.00% <ø> (ø)
x/profiles/client/cli/cli_relationships.go 75.51% <ø> (ø)
x/profiles/client/cli/query.go 0.00% <ø> (ø)
x/profiles/client/cli/tx.go 0.00% <ø> (ø)
x/profiles/client/utils/cli.pb.go 3.12% <ø> (ø)
x/profiles/client/utils/utils.go 56.25% <ø> (ø)
x/profiles/keeper/alias_functions.go 90.47% <ø> (ø)
x/profiles/keeper/genesis.go 84.61% <ø> (ø)
x/profiles/keeper/grpc_query.go 73.78% <ø> (ø)
... and 196 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac13c3...8eca2c3. Read the comment docs.

@RiccardoM RiccardoM added the automerge Automatically merge PR once all prerequisites pass label Oct 26, 2021
@mergify mergify bot merged commit 2db994c into master Oct 26, 2021
@mergify mergify bot deleted the riccardo/app-links-fix branch October 26, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Automatically merge PR once all prerequisites pass x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot verify an app link correctly
3 participants