feat: Break up duplicate-id rule for ARIA+labels and for active elements #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanb
requested changes
Aug 24, 2018
| "impact": "critical", | ||
| "messages": { | ||
| "pass": "Document has no elements referenced with ARIA or labels that share the same id attribute", | ||
| "fail": "Document has multiple elements referenced with ARIA or with the same id attribute: {{=it.data}}" |
There was a problem hiding this comment.
Change to Document has multiple elements referenced with ARIA with the same id attribute: {{=it.data}}
lib/checks/parsing/duplicate-id.json
Outdated
| @@ -3,7 +3,7 @@ | |||
| "evaluate": "duplicate-id.js", | |||
| "after": "duplicate-id-after.js", | |||
| "metadata": { | |||
| "impact": "moderate", | |||
| "impact": "minor", | |||
| "messages": { | |||
| "pass": "Document has no elements that share the same id attribute", | |||
| "fail": "Document has multiple elements with the same id attribute: {{=it.data}}" | |||
There was a problem hiding this comment.
Change this to Document has multiple static elements with the same id attribute?
| </div> | ||
|
|
||
| <button id="fail1" class="fail1"></button> | ||
| <button id="fail1"></button> |
There was a problem hiding this comment.
Should we have more examples of failures? For example a <div tabindex="-1" id="fail2">blah</div><input id="fail2" /> etc.?
dylanb
approved these changes
Aug 24, 2018
This was referenced Feb 25, 2020
|
It took us a while to find it, but thanks for doing this. We really like this approach and agree it's got much higher signal:noise. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break the duplicate-id rule up into three rules:
Closes #163
Reviewer checks
Required fields, to be filled out by PR reviewer(s)