Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow the unique ID attribute audit to just affected forms/table headers #10374

Closed
onepack opened this issue Feb 24, 2020 · 7 comments
Closed

Comments

@onepack
Copy link

onepack commented Feb 24, 2020

Provide the steps to reproduce

  1. Run LH on dochorse.nl

What is the current behavior?

[id] attributes on the page are not unique
The value of an id attribute must be unique to prevent other instances from being overlooked by assistive technologies. Learn more.
Failing Elements

span#product-price-7393.price-wrapper
span#product-price-7369.price-wrapper
span#product-price-7372.price-wrapper
span#product-price-7352.price-wrapper
span#product-price-7332.price-wrapper
span#product-price-7423.price-wrapper
span#product-price-7416.price-wrapper
span#product-price-7418.price-wrapper
span#product-price-7408.price-wrapper
span#product-price-7413.price-wrapper

What is the expected behavior?

They are unique!
They have a unique number. Searching source of the page for a duplicate gives me only 1/1 hit.
So how can it be a duplicate?

Environment Information

  • Affected Channels:
  • Lighthouse version: No idea where to find this info, it's build into the browser dev tools.
  • Chrome version: 80.0.3987.116
  • Node.js version:
  • Operating System: Windows10

Related issues

@connorjclark
Copy link
Collaborator

image

@connorjclark
Copy link
Collaborator

oops, didn't mean to close

team, maybe we could list (at most 2) the duplicate elements in the report? we just show+linkify one atm.

@connorjclark connorjclark reopened this Feb 24, 2020
@onepack
Copy link
Author

onepack commented Feb 24, 2020

Thank you for your swift reply.
My wrong! I see now it's the dynamic rendering of the carousel items that creates duplicates.
Looking for the duplicates in the the static source of the page will never work then.

@patrickhulce patrickhulce changed the title The value of an id attribute must be unique Surface multiple elements for unique ID attribute audit Feb 25, 2020
@patrickhulce patrickhulce changed the title Surface multiple elements for unique ID attribute audit Narrow the unique ID attribute audit to just affected forms/table headers Feb 25, 2020
@patrickhulce
Copy link
Collaborator

@connorjclark to report our concerns to axe :)

@connorjclark
Copy link
Collaborator

dequelabs/axe-core#1097 they already did the narrowing we want :)

@connorjclark
Copy link
Collaborator

so we use duplicate-id-aria and duplicate-id-active. should we just turn of duplicate-id?

@connorjclark
Copy link
Collaborator

LOL we already do this. nvm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants