Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show multiple elements for duplicate id checks #10396

Closed
connorjclark opened this issue Feb 27, 2020 · 1 comment · Fixed by #13193
Closed

Show multiple elements for duplicate id checks #10396

connorjclark opened this issue Feb 27, 2020 · 1 comment · Fixed by #13193
Assignees
Labels

Comments

@connorjclark
Copy link
Collaborator

connorjclark commented Feb 27, 2020

Use the relatedNodes field from duplicate-id-aria and duplicate-id-active checks to show multiple elements for each id. The goal is to increase actionability and decrease confusion ("Lighthouse is wrong...")

We can:

  • show no more than two for each unique id
  • show maybe, like, up to 5, and use subitems to group it nicely

Related:
#10374

Confusion:
#4313
#4833
#5561
#6489
#8399
#10374
#10856
#12908

bonus search keywords from audit title: ARIA IDs are unique

@connorjclark
Copy link
Collaborator Author

  1. id as a column
  2. show up to 3 duplicates as sub items (including devtools node path)
  3. show count of duplicates in new column
  4. patrick is flabbergasted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants