Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[id] attributes on the page are not unique and noscript tag #8399

Closed
Lofesa opened this issue Apr 18, 2019 · 2 comments
Closed

[id] attributes on the page are not unique and noscript tag #8399

Lofesa opened this issue Apr 18, 2019 · 2 comments

Comments

@Lofesa
Copy link

Lofesa commented Apr 18, 2019

Hi
I have a web that run the pagespeed module , These module has a filter to inline the css critical path and delay the load of all other css stuff.
To make this delay, the module put all css stuff (css files and inlined css) between noscript tags with a class (psa_add_styles) and the result is that the css elements with ID appear 2 times.
Can it be considered that the IDs are duplicated when they appear between noscript labels?
URL to test https://intersindicalrm.org/
This fails on LH in Chrome and in web.dev.

Thx in advance

@patrickhulce
Copy link
Collaborator

Thanks for filing @Lofesa but Lighthouse seems to be accurate here.

I see two copies of this ID on that page outside of <noscript> regions.

image

image

@Lofesa
Copy link
Author

Lofesa commented Apr 19, 2019

Hi
Thx you @patrickhulce for the time....
Is a pagespeed module fail, it must remove all inlined styles and put it on a nonscript tag and then inject the critical css path and delay the load of the rest off css files and inlined styles, but in this case it make a copy of the inlined css in the noscript tag and don´t delete the original so it get 2 inlined styles, the original and the delayed. I will fire a bug to the pagespeed module team.
Again, thx you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants