Don't leak pipenv warnings into manifest files #6103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honeyankit
approved these changes
Nov 10, 2022
1 task
deivid-rodriguez
force-pushed
the
deivid-rodriguez/error-leaked-to-manifests
branch
from
3d07a82 to
9c1447c
Compare
deivid-rodriguez
deleted the
deivid-rodriguez/error-leaked-to-manifests
branch
1 task
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix focused on #6090, but we may want to consider unifying and reviewing all helpers that shell out, because this same thing is likely to be happening in other places.
I guess we could also log warnings somewhere, not sure.
I thought of a adding a spec but it was a bit tricky.
Fixes #6090.