Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit code for use of Open3.capture2e() #6130

Closed
1 task done
jeffwidman opened this issue Nov 14, 2022 · 2 comments
Closed
1 task done

Audit code for use of Open3.capture2e() #6130

jeffwidman opened this issue Nov 14, 2022 · 2 comments

Comments

@jeffwidman
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Code improvement description

From #6103

I've only seen stdout, _, process = Open3.capture3(env, command) used in our code, but we should audit the code for any other usages of Open3.capture2e to see if we have risks of hitting this in other envs... and if so, why are we using capture2e rather than capture3?

@deivid-rodriguez
Copy link
Contributor

I actually opened #6110 which is basically the same thing?

@jeffwidman
Copy link
Member Author

Ha, so you did! I'm still catching up on notifications and hadn't seen that. Thank you!

@jeffwidman jeffwidman closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants