Bump base image in docker push workflow to 20.04
#5432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've been running on `20.04` since #4394, I just didn't realize this actions workflow also pinned the version. So this bumps to our current base image. Unfortunately, this will likely be outdated in the future again, once #5030 lands... and likely to be an ongoing issue. I wish there was an easy way to extract this value from the Dockerfile, but everything I come up with seems quite hacky/brittle.
jurre
approved these changes
Jul 27, 2022
|
True I didn't even think of that as an option. A workflow to verify would be great, but again, tough to keep it up to date. I guess for now just ignore it unless something pops to mind suddenly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been running on
20.04since #4394, I just didn't realize this actions workflow also pinned the version. So this bumps to our current base image.Unfortunately, this will likely be outdated in the future again, once #5030 lands... and likely to be an ongoing issue of drift whenever we bump Ubuntu versions.
I wish there was an easy way to extract this value from the Dockerfile, but everything I come up with seems quite hacky/brittle.