Bump underlying `ubuntu` to `22.04` LTS #5030

jeffwidman · 2022-04-22T18:52:55Z

22.04 LTS dropped yesterday: https://ubuntu.com/blog/ubuntu-22-04-lts-released

I'm not sure of the GitHub internal infra, there may be security/infra reasons blocking
this upgrade that are not visible to external contributors, but thought I'd at least open
this PR to see what CI thinks.

For the Erlang issue, I had to install Erlang from Ubuntu Universe rather than Erlang Solutions.
Unfortunately that means we will probably lag on Erlang versions in the future.

While this isn't ideal from an Erlang perspective, this unblocks the
22.04 upgrade, which is a bigger deal for the other ecosystems.

I'm hopeful this is only a temporary state of affairs and someone from
the community steps up to provide a PR switching to installing from
either the Erlang Solutions PPA or the RabbitMQ PPA.

mattt · 2022-07-12T14:55:33Z

@jeffwidman I just merged #5356, which should unblock us from upgrading to LTS. Can you rebase and try again with this PR?

jeffwidman · 2022-07-26T23:30:09Z

Thanks @mattt, just saw your comment.

Rebased!

We've been running on `20.04` since #4394, I just didn't realize this actions workflow also pinned the version. So this bumps to our current base image. Unfortunately, this will likely be outdated in the future again, once #5030 lands... and likely to be an ongoing issue. I wish there was an easy way to extract this value from the Dockerfile, but everything I come up with seems quite hacky/brittle.

.github/workflows/docker.yml

jeffwidman · 2022-07-27T06:52:29Z

CI failures are because Ubuntu 22.04 uses OpenSSL 3.0, which requires Ruby >= 3.1... see ruby/setup-ruby#333 (comment).

The workaround is to manually compile openssl lib before installing Ruby... but that turns into quite the implementation rabbit-hole: rbenv/ruby-build#1974

Dockerfile

jeffwidman · 2022-07-27T07:38:54Z

So at this point, due to the problems with Ruby < 3.1 requiring an older OpenSSL than Ubuntu 22.04 ships, we have several options:

manually compile the relevant OpenSSL lib, and then somehow tell our downloaded Ruby how to use it... example: Cannot build rubies 2.6.x, 2.7.x and 3.0.x on Ubuntu 22.04 because they relies on openssl1.1 and Ubuntu now provides openssl3 rvm/rvm#5209 (comment)
Manually add a PPA with a pre-compiled OpenSSL (example), downgrade libSSL, then use that... feels very brittle though... esp given https://bugs.ruby-lang.org/issues/18658#note-2.
bump to Ruby 3.1, we need to do this anyway at some point, not sure how much work it is, or if we'd run into problems with GitHub internal infra... but we might be okay on the infra part since we're silo'd into our own docker image, IDK.
switch to using rbenv/ruby-build since at first glance it will "just work" due to Install openssl whenever the system openssl version is not supported by a Ruby rbenv/ruby-build#1974. However, we originally went with ruby-install instead of ruby-build for some good reasons.
Wait a while, and see what shakes out further in the Ruby ecosystem... most of the open source discussions I've seen are within the past month, so I have a hunch waiting another 3-6 months will result in a bit more clarity/standardization on how others are dealing with this problem. Since I doubt most folks jumping to 22.04 will be willing/able to drop Ruby < 3.1...

Everything I've read so far makes it seem very brittle/painful to manage old OpenSSL versions, so I vote for working towards option 3 which will implicitly result in also picking option 5.

Thoughts?

jurre · 2022-07-27T08:33:41Z

I'm all for bumping the ruby version, @mattt's work on using ruby-install unblocks us, I think that's the main reason that we haven't done it yet, it should be a doable upgrade from my experience.

jeffwidman · 2022-07-29T06:20:55Z

Sounds good to me, I opened #5447 to bump to 3.1.

I think my main concern was that something internal within GitHub tooling that we may use now or in the near future may not be ready to support Ruby 3.1... but I suppose we can always try it and if we run into problems we can revert or push those teams to start providing support for 3.1... Anyway, we'll see how that PR goes.

jurre · 2022-07-29T07:37:22Z

GitHub tooling that we may use now or in the near future may not be ready to support Ruby 3.

Most internal things are on the latest or even pre-release versions of ruby and rails, dependabot, a bot that updates your dependencies, being on older versions is a cruel paradox

deivid-rodriguez

Awesome job!

jakecoffman · 2023-08-22T12:48:41Z

Dockerfile.updater-core

@@ -90,14 +90,14 @@ WORKDIR $DEPENDABOT_HOME/dependabot-updater

 # Install Ruby from official Docker image
 # When bumping Ruby minor, need to also add the previous version to `bundler/helpers/v{1,2}/monkey_patches/definition_ruby_version_patch.rb`
-COPY --from=ruby:3.1.4-bullseye --chown=dependabot:dependabot /usr/local /usr/local
+COPY --from=ruby:3.1.4-bookworm --chown=dependabot:dependabot /usr/local /usr/local


We could base the image off of the ruby image and delete this line, and then get Dependabot bumps for it.

It's an interesting idea for sure, but I'd rather do it after this PR lands. I considered switching to --from=ruby:3.1.4 since today it's the same as ruby:3.1.4-bookworm but we used to do that and ran into problems when it switched its base debian image under our feet to one that conflicted with our version of Ubuntu used elsewhere... it'd probably be okay if it were the base image, but still let's postpone looking at that to a later PR and here just catch us up to a newer Ubuntu.

jakecoffman · 2023-08-22T12:55:14Z

Should we update the Swift Dockerfile to install the 22.04 version?

abdulapopoola · 2023-08-22T15:58:15Z

Dockerfile.updater-core


 # When bumping Bundler, need to also regenerate `updater/Gemfile.lock` via `bundle update --lock --bundler`
 # Generally simplest to match the bundler version to the one that comes by default with whatever Ruby version we install.
 # This way other projects that import this library don't have to futz around with installing new / unexpected bundler versions.
 ARG BUNDLER_V2_VERSION=2.4.17

-# We had to explicitly bump this as the bundled version `0.2.2` in ubuntu 20.04 has a bug.
+# We had to explicitly bump this as the bundled version `0.2.2` in ubuntu 22.04 has a bug.


Does the new version of Ubuntu handle the yaml parsing now? And can we therefore undo this PR

Not yet, unfortunately.

I wish we could, but we'll need Ubuntu 23.04 before we get a new enough version:

https://packages.ubuntu.com/search?suite=default&section=all&arch=any&keywords=libyaml-0-2&searchon=names

We have a PR to bump to 23.04, but probably should land this PR first, and then also have a conversation about do we even want to bump to non-LTS versions:

Bump ubuntu from 20.04 to 23.04 #6561

abdulapopoola · 2023-08-22T15:59:51Z

Would this need to be updated too?

abdulapopoola · 2023-08-22T16:00:46Z

And this spec file too?

jeffwidman · 2023-08-22T16:17:23Z

swift/Dockerfile

@@ -25,7 +25,7 @@ USER dependabot

 # https://www.swift.org/download/
 ARG SWIFT_VERSION=5.8.1
-ARG SWIFT_UBUNTU_VERSION=ubuntu20.04
+ARG SWIFT_UBUNTU_VERSION=ubuntu22.04


Great catch @jakecoffman , this crept in the last few months, and I completely forgot to re-grep for any new 20.04 references.

jeffwidman · 2023-08-22T16:55:38Z

Would this need to be updated too?

No, this is just testing a docker tag. In fact better if it test for a tag that isn't our image just to ensure there's no coupling.

And this spec file too?

Same as above, this is just a spec of a user's manifest... so their Ubuntu version shouldn't matter relative to our Ubuntu version.

That said, I really appreciate you and Jake for grep'ing for other references and double-checking this. I completely forgot to look for any others that crept in over the past year.

`22.04` LTS dropped yesterday: https://ubuntu.com/blog/ubuntu-22-04-lts-released

Install Erlang from Ubuntu Universe rather than Erlang Solutions. Unfortunately that means we will probably lag on Erlang versions in the future. While this isn't ideal from an Erlang perspective, this unblocks the `22.04` upgrade, which is a bigger deal for the other ecosystems. I'm hopeful this is only a temporary state of affairs and someone from the community steps up to provide a PR switching to installing from either the Erlang Solutions PPA or the RabbitMQ PPA. See also: * esl/packages#15 * dependabot#7865 * https://erlangforums.com/t/erlang-solutions-apt-package-for-otp-25/1552/1 * https://erlangforums.com/t/the-eef-is-looking-for-volunteers-to-take-over-esls-build-packages/2238/1

jeffwidman · 2023-08-22T19:38:50Z

And a year and a half later I can finally hit the 🟢 button! 😁

jeffwidman requested a review from a team as a code owner April 22, 2022 18:52

jeffwidman mentioned this pull request May 21, 2022

Bump Ruby to 2.7.6 #5157

Closed

DavidTurner-N mentioned this pull request Jun 16, 2022

Install Ruby with rbenv #5190

Closed

jeffwidman force-pushed the patch-4 branch from bcc25ef to 0aec661 Compare July 26, 2022 23:29

This was referenced Jul 26, 2022

Add dependabot updates for Dockerfiles #5428

Merged

build(deps): bump ubuntu from 20.04 to 22.04 #5431

Closed

jeffwidman mentioned this pull request Jul 27, 2022

Bump base image in docker push workflow to 20.04 #5432

Merged

jeffwidman force-pushed the patch-4 branch from 0aec661 to d2bb47e Compare July 27, 2022 05:37

jeffwidman commented Jul 27, 2022

View reviewed changes

.github/workflows/docker.yml Outdated Show resolved Hide resolved

jeffwidman commented Jul 27, 2022

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

jeffwidman force-pushed the patch-4 branch from 538cd29 to 8eb3db1 Compare July 28, 2022 14:34

jeffwidman mentioned this pull request Jul 29, 2022

Migrate from actions/setup-ruby to ruby/setup-ruby #5433

Merged

jeffwidman mentioned this pull request Jul 29, 2022

Bump Ruby to 3.1 #5447

Merged

jeffwidman self-assigned this Aug 3, 2023

jeffwidman force-pushed the patch-4 branch from 5b3957d to dd6505f Compare August 21, 2023 18:09

github-actions bot removed the L: python label Aug 21, 2023

jeffwidman force-pushed the patch-4 branch 2 times, most recently from 6fb060e to f6887d3 Compare August 22, 2023 05:58

jeffwidman marked this pull request as ready for review August 22, 2023 05:58

jeffwidman mentioned this pull request Aug 22, 2023

Switch to RabbitMQ Erlang PPA #7865

Closed

deivid-rodriguez approved these changes Aug 22, 2023

View reviewed changes

deivid-rodriguez mentioned this pull request Aug 22, 2023

Parallelize tests #6590

Merged

landongrindheim approved these changes Aug 22, 2023

View reviewed changes

jakecoffman reviewed Aug 22, 2023

View reviewed changes

abdulapopoola reviewed Aug 22, 2023

View reviewed changes

github-actions bot added the L: swift Swift packages label Aug 22, 2023

jeffwidman commented Aug 22, 2023

View reviewed changes

jeffwidman force-pushed the patch-4 branch from 76b1b9e to 7fc6424 Compare August 22, 2023 16:59

jeffwidman added 4 commits August 22, 2023 11:19

Bump underlying ubuntu to 22.04 LTS

c610589

`22.04` LTS dropped yesterday: https://ubuntu.com/blog/ubuntu-22-04-lts-released

ubuntu 22.04 is based off debian bookworm

9c67417

Bump Swift docker image to Ubuntu 22.04

b7df98a

jeffwidman force-pushed the patch-4 branch from 7fc6424 to b7df98a Compare August 22, 2023 18:19

jeffwidman merged commit e2f74f3 into dependabot:main Aug 22, 2023

jeffwidman deleted the patch-4 branch August 22, 2023 19:39

leonardoadame mentioned this pull request Mar 23, 2024

[Snyk] Security upgrade npm from 8.11.0 to 8.13.0 leonardoadame/dependabot-core#512

Open

leonardoadame mentioned this pull request Apr 8, 2024

[Snyk] Security upgrade npm from 8.11.0 to 8.13.0 leonardoadame/dependabot-core#543

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump underlying `ubuntu` to `22.04` LTS #5030

Bump underlying `ubuntu` to `22.04` LTS #5030

jeffwidman commented Apr 22, 2022 •

edited

Loading

mattt commented Jul 12, 2022

jeffwidman commented Jul 26, 2022

jeffwidman commented Jul 27, 2022 •

edited

Loading

jeffwidman commented Jul 27, 2022 •

edited

Loading

jurre commented Jul 27, 2022

jeffwidman commented Jul 29, 2022

jurre commented Jul 29, 2022

deivid-rodriguez left a comment

jakecoffman Aug 22, 2023

jeffwidman Aug 22, 2023

jakecoffman commented Aug 22, 2023

abdulapopoola Aug 22, 2023

deivid-rodriguez Aug 22, 2023

jeffwidman Aug 22, 2023

abdulapopoola commented Aug 22, 2023

abdulapopoola commented Aug 22, 2023

jeffwidman Aug 22, 2023

jeffwidman commented Aug 22, 2023

jeffwidman commented Aug 22, 2023

Bump underlying ubuntu to 22.04 LTS #5030

Bump underlying ubuntu to 22.04 LTS #5030

Conversation

jeffwidman commented Apr 22, 2022 • edited Loading

mattt commented Jul 12, 2022

jeffwidman commented Jul 26, 2022

jeffwidman commented Jul 27, 2022 • edited Loading

jeffwidman commented Jul 27, 2022 • edited Loading

jurre commented Jul 27, 2022

jeffwidman commented Jul 29, 2022

jurre commented Jul 29, 2022

deivid-rodriguez left a comment

Choose a reason for hiding this comment

jakecoffman Aug 22, 2023

Choose a reason for hiding this comment

jeffwidman Aug 22, 2023

Choose a reason for hiding this comment

jakecoffman commented Aug 22, 2023

abdulapopoola Aug 22, 2023

Choose a reason for hiding this comment

deivid-rodriguez Aug 22, 2023

Choose a reason for hiding this comment

jeffwidman Aug 22, 2023

Choose a reason for hiding this comment

abdulapopoola commented Aug 22, 2023

abdulapopoola commented Aug 22, 2023

jeffwidman Aug 22, 2023

Choose a reason for hiding this comment

jeffwidman commented Aug 22, 2023

jeffwidman commented Aug 22, 2023

Bump underlying `ubuntu` to `22.04` LTS #5030

Bump underlying `ubuntu` to `22.04` LTS #5030

jeffwidman commented Apr 22, 2022 •

edited

Loading

jeffwidman commented Jul 27, 2022 •

edited

Loading

jeffwidman commented Jul 27, 2022 •

edited

Loading